System and Lockscreen clocks use custom code to remove dayperiod from the result time string after formatting. We recently started working on including this feature in Intl API and developed mozIntl API as a temporary shim. The version in mozIntl is better (it properly reacts to a bug in our automatic timezone handling), so let's switch to it.

Comment on attachment 8666437 [details] [gaia] zbraniecki:1208806-switch-clocks-to-mozintl > mozilla-b2g:master Tim, this patch moves System statusbar time_icon and Lockscreen time formatting to mozIntl.DateTimeFormat which is an extension of Intl API that incorporates changes that we are planning to add to Intl API rev 3. You can read about those API extensions here: * https://github.com/tc39/ecma402/issues/29 * https://github.com/tc39/ecma402/issues/30 My goal is to centralize those use cases to make it easier to maintain the code and later transition us to full Intl API once we finalize the spec and implement the changes in Gecko.

Tim, of course I only wanted to ask for the review of the second patch in this group. The first one is being reviewed by :stas in bug 1208698.

Comment on attachment 8666437 [details] [gaia] zbraniecki:1208806-switch-clocks-to-mozintl > mozilla-b2g:master Trying a different reviewer to offload Tim a bit :)

Comment on attachment 8666437 [details] [gaia] zbraniecki:1208806-switch-clocks-to-mozintl > mozilla-b2g:master LGTM. Thanks!

Thanks Alberto! Commit: https://github.com/mozilla-b2g/gaia/commit/21f5444f7133710b777103376168bc606c20b9dc