Closed Bug 1208889 Opened 9 years ago Closed 9 years ago

Migrate mozL10n.DateTimeFormat to Intl API in Email

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

There are two places in Email where we use deprecated mozIntl.DateTimeFormat. I'm aiming to remove l10n_date overall in this cycle, so I'd like to move them to mozIntl.
Attached file pull request (deleted) —
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Depends on: 1208698
Depends on: 1209821
Comment on attachment 8666507 [details] pull request Ok, I think it's ready for review. It's part of an attempt to get rid of l10n_date in 2.5 and migrate everything to Intl or mozIntl APIs. Should be painless :)
Attachment #8666507 - Flags: review?(bugmail)
Comment on attachment 8666507 [details] pull request A quick pass suggests it's all good, but especially since this touches app startup, James is the best/most appropriate reviewer.
Attachment #8666507 - Flags: review?(bugmail) → review?(jrburke)
Comment on attachment 8666507 [details] pull request Review comments in pull request, please flip review back to me when you want me to do another review pass.
Attachment #8666507 - Flags: review?(jrburke)
Comment on attachment 8666507 [details] pull request Ok, let me know what you think! I added a new method to our private mozIntl._gaia.RelativeDate which formats elements. I also applied your patch except of not adding moz_intl as a dependency on l10n, since it is not required. Let me know what you think!
Attachment #8666507 - Flags: review?(jrburke)
Comment on attachment 8666507 [details] pull request Great to have a non-async way to set the relative time. I left some comments and a diff in the pull request, feel free to flip review back when ready. If no other substantive changes from the diff, then I expect it will be a quick final review.
Attachment #8666507 - Flags: review?(jrburke)
Comment on attachment 8666507 [details] pull request Sweet! I may want to squeeze a couple tests in this patch for mozIntl._gaia.formatElement, but your part is ready for r? (I also got ircal* f+ from :stas on mozIntl changes). *) that's IRC equivalent of verbal
Attachment #8666507 - Flags: review?(jrburke)
Comment on attachment 8666507 [details] pull request r+ with just one nit in the pull request around the number of RelativeDate calls. Thanks for upgrading the email app!
Attachment #8666507 - Flags: review?(jrburke) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: