Closed
Bug 1208973
Opened 9 years ago
Closed 9 years ago
Intermittent test_basic_pan.html | application crashed [@ mozalloc_abort]
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: nigelb, Assigned: kats)
References
Details
(Keywords: intermittent-failure)
Attachments
(3 files)
No description provided.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1208973 - Refactor and add logging to TaskThrottler. r=
Attachment #8669380 -
Flags: review?(botond)
Assignee | ||
Comment 6•9 years ago
|
||
Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=
Attachment #8669381 -
Flags: review?(botond)
Assignee | ||
Comment 7•9 years ago
|
||
Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=
Hat tip to :froydnj for describing the proof-of-lock technique used in this patch
in his blog at https://blog.mozilla.org/nfroyd/2015/09/17/compiler-enforced-locked-accesses/
Attachment #8669382 -
Flags: review?(botond)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bugmail.mozilla
Updated•9 years ago
|
Attachment #8669380 -
Flags: review?(botond) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8669380 [details]
MozReview Request: Bug 1208973 - Refactor and add logging to TaskThrottler. r=
https://reviewboard.mozilla.org/r/21199/#review19153
Comment 9•9 years ago
|
||
Comment on attachment 8669381 [details]
MozReview Request: Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=
https://reviewboard.mozilla.org/r/21201/#review19155
Attachment #8669381 -
Flags: review?(botond) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8669382 [details]
MozReview Request: Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=
https://reviewboard.mozilla.org/r/21203/#review19159
I like the proof-of-lock technique, thanks for bringing it to my attention!
::: gfx/layers/apz/src/TaskThrottler.h:15
(Diff revision 1)
> #include "mozilla/UniquePtr.h" // for UniquePtr
#include "mozilla/Monitor.h"
Attachment #8669382 -
Flags: review?(botond) → review+
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c3218e220831
https://hg.mozilla.org/mozilla-central/rev/ca9e202ceb12
https://hg.mozilla.org/mozilla-central/rev/dbe92d963519
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•