Closed Bug 1209054 Opened 9 years ago Closed 9 years ago

Allow screen reader user to pause/suspend speech.

Categories

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Accessibility
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2r+, firefox44 fixed, b2g-v2.2r fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S8 (02Oct)
Project Flags:
feature-b2g 2.2r+
Tracking Flags:
Tracking Status
firefox44 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: yzen, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(3 files)

Make 2 finger tap toggle pause speech
(deleted), patch
yzen
: review+
Details | Diff | Splinter Review
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/32105
(deleted), text/x-github-pull-request
timdream
: review+
Details
[gaia] eeejay:bug-1209054-v22r > mozilla-b2g:v2.2r
(deleted), text/x-github-pull-request
Details 
Screen reader user should be able to pause/suspend speech at any time.

We want to implement the following:

* User can pause speech with a gesture
* If user unpauses without any actions in after pausing, the speech should resume
* If user performs an action after pausing, screen reader speech cancels and new event is spoken.
Assignee: nobody → eitan

        Attachment #8667258 -
        Flags: review?(yzenevich)

    
  

        Attachment #8667300 -
        Attachment description: [gaia] eeejay:bug-1209054 > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/32105

        Attachment #8667300 -
        Flags: review?(timdream)

    
    

    
  
Comment on attachment 8667258 [details] [diff] [review]
Make 2 finger tap toggle pause speech

Review of attachment 8667258 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thanks!

        Attachment #8667258 -
        Flags: review?(yzenevich) → review+

        Attachment #8667300 -
        Flags: review?(timdream) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/169bf2e577a2
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
feature-b2g: --- → 2.2r+

    
    

    
  
I believe we need it for RedTai/RedSquare
Flags: needinfo?(eitan)

    
    

    
  
The pull request will conflict with the request from bug 1209054, but it should be easy to resolve.
Flags: needinfo?(eitan)

    
    

    
  
Attachement #8667258 applies cleanly on b2g37_v2_2.

    
    

    
  
Attachment #8667258 [details] [diff] applies cleanly on b2g37_v2_2.

    
    

    
  
Comment on attachment 8667258 [details] [diff] [review]
Make 2 finger tap toggle pause speech

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: User will not be able to pause resume speech.
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Little, none.
String or UUID changes made by this patch:

        Attachment #8667258 -
        Flags: approval‑mozilla‑b2g37_v2_2r?

    
  
Keywords: checkin-needed

    
    

    
  
This branch has conflicts that must be resolved. Could you take a look at this ? Thanks !
Flags: needinfo?(eitan)

    
    

    
  
Rebased!
Flags: needinfo?(eitan)

    
    

    
  
Comment on attachment 8667258 [details] [diff] [review]
Make 2 finger tap toggle pause speech

Removing request due to cancellation of red-tai.

        Attachment #8667258 -
        Flags: approval‑mozilla‑b2g37_v2_2r?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: