Closed Bug 1209401 Opened 9 years ago Closed 9 years ago

Don't use preprocessor forced includes for API keys in nsURLFormatter.js

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Don't use preprocessor forced includes for API keys in nsURLFormatter.js
(deleted), patch
gps
: review+
Details | Diff | Splinter Review
No description provided.
I think this is the only use of the -I option to preprocessor.py in the tree. I'll do a try build to see if we can just remove that option, which I always found confusing, since it doesn't match the C preprocessor at all.
Attachment #8667107 - Flags: review?(gps)
Comment on attachment 8667107 [details] [diff] [review] Don't use preprocessor forced includes for API keys in nsURLFormatter.js Review of attachment 8667107 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8667107 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0eedb958866d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: