J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Description • 9 years ago

The target.js API has WindowTargets (in addition to the well used TabTargets), but no one uses them anymore.

There is one use[1] of `TargetFactory.forWindow` in `toggleBrowserToolboxCommand` from gDevTools.jsm, but nothing calls that either.

[1]: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/gDevTools.jsm#555

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 1 • 9 years ago

:past, any reason to keep this stuff around?

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 2 • 9 years ago

No, I don't think so. WindowTarget was there to support tools that hadn't been made remote yet, but nowadays there aren't any that we care about (plus it's only tabs these days, we do things differently for browser debugging). Kill it!

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 3 • 9 years ago

Bug 1209634 - Remove unused WindowTarget. r=past

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 4 • 9 years ago

Bug 1209634 - Remove unused target.version. r=past

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 5 • 9 years ago

Bug 1209634 - Reformat target.js to match ESLint rules. r=past

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 6 • 9 years ago

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5ad5617cb4f

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 7 • 9 years ago

Comment on attachment 8668725 [details]
MozReview Request: Bug 1209634 - Remove unused WindowTarget. r=past

https://reviewboard.mozilla.org/r/21019/#review19329

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 8 • 9 years ago

Comment on attachment 8668726 [details]
MozReview Request: Bug 1209634 - Remove unused target.version. r=past

https://reviewboard.mozilla.org/r/21021/#review19331

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 9 • 9 years ago

Comment on attachment 8668727 [details]
MozReview Request: Bug 1209634 - Reformat target.js to match ESLint rules. r=past

https://reviewboard.mozilla.org/r/21023/#review19333

	Pulsebot
	Comment 10 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/b5993cbe1873
https://hg.mozilla.org/integration/fx-team/rev/404ae1b08e79
https://hg.mozilla.org/integration/fx-team/rev/9d03bc7fad05

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 11 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/b5993cbe1873
https://hg.mozilla.org/mozilla-central/rev/404ae1b08e79
https://hg.mozilla.org/mozilla-central/rev/9d03bc7fad05