Currently, during a test's setup_job logcat is collected and reset prior to necessary initialization. If the logcat fails due to an ADBError or ADBTimeoutError, this can leave the test partially uninitialized causing start_time, stop_time and job_details to not be set/reset.

Comment on attachment 8667428 [details] [diff] [review] bug-1209651-setup-job-init-v1.patch Review of attachment 8667428 [details] [diff] [review]: ----------------------------------------------------------------- I don't understand how this fixes the issue, we just moved the logcat access a few lines later?

Comment on attachment 8667428 [details] [diff] [review] bug-1209651-setup-job-init-v1.patch Yes. The appropriate properties are initialized before the logcat call can cause an ADBError/ADBTimeout Error. If the error did occur, it will be caught in the worker.py's PhoneWorkerSubProcess::run_tests try...except block at https://github.com/mozilla/autophone/blob/master/worker.py#L677 and the failure handled there. It is necessary that these properties be initialized even if the setup_job failed since we will use them when reporting the failure to Treeherder.

Comment on attachment 8667428 [details] [diff] [review] bug-1209651-setup-job-init-v1.patch Review of attachment 8667428 [details] [diff] [review]: ----------------------------------------------------------------- thanks for the explanation!