Closed
Bug 1209653
Opened 9 years ago
Closed 9 years ago
Autophone - after clearing logcat, specifying -b main can hang
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox44 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I've noticed this especially during testing when I disable/usercancel jobs submitted to staging treeherder.
If you clear logcat -c then issue a logcat -d -b main, it will hang until there is more data written to the logcat. This was caused when we added buffers to adb's logcat and defaulted to -b main if none were specified in Bug 1156812.
If all we want is the main logcat buffer, there is no need to specify it explicitly and removing the -b main from the command solves the hang problem. I am fixing this locally here in Autophone but this could/should also be changed in mozdevice's copy as well.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8667432 -
Flags: review?(jmaher)
Comment 2•9 years ago
|
||
Comment on attachment 8667432 [details] [diff] [review]
bug-1209653-do-not-default-to-logcat-main-v1.patch
Review of attachment 8667432 [details] [diff] [review]:
-----------------------------------------------------------------
do we need to resolve this in the clear_logcat as well?
Attachment #8667432 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Probably, I noticed that when I was explaining in irc as well. I'll make that change locally before I push. Thanks!
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1156812 introduced the use of logcat buffers. This appears to be the cause of the previously unexplained "apparent" improvement on 8/21 noticed by mfinkle on 8/25
See http://phonedash.mozilla.org/#/org.mozilla.fennec/throbberstart/local-blank/norejected/2015-08-19/2015-08-24/notcached/noerrorbars/standarderror/notry
This patch will revert that change and will introduce an "apparent" regression which is not real.
The difference appears to be due to the change in the "start" time used to convert the raw Throbber measurements into a value relative to when Gecko/Fennec starts. Looking at this, I do see some opportunity to improve analyze_logcat in s1s2 at least, but I will treat that as a separate bug.
Assignee | ||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•