Closed
Bug 1209887
Opened 9 years ago
Closed 9 years ago
Remove usage of decoder monitor from WaveReader
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jwwang
Blocks: MediaMonitor
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Bug 1209887 - Remove usage of decoder monitor from WaveReader.
Attachment #8668241 -
Flags: review?(jyavenard)
|
||
Updated•9 years ago
|
Attachment #8668241 -
Flags: review?(jyavenard) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8668241 [details]
MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.
https://reviewboard.mozilla.org/r/20911/#review18815
The commit message is highly confusing as it does way more than removing the monitor : removing GetNextChunk which isn't used ; adding asserts etc.
maybe it would be better to split this patch between functional and tidying things up
|
|
Assignee | |
Comment 4•9 years ago
|
||
Sure. I will split the patch. Thanks for the review!
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8668241 [details]
MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.
Bug 1209887. Part 1 - add assertions. r=jya.
Attachment #8668241 -
Attachment description: MozReview Request: Bug 1209887 - Remove usage of decoder monitor from WaveReader. → MozReview Request: Bug 1209887. Part 1 - add assertions. r=jya.
|
|
Assignee | |
Comment 6•9 years ago
|
||
Bug 1209887. Part 2 - remove usage of decoder monitor. r=jya.
Attachment #8668343 -
Flags: review?(jyavenard)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Bug 1209887. Part 3 - remove unused code. r=jya.
Attachment #8668344 -
Flags: review?(jyavenard)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8668343 -
Flags: review?(jyavenard) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8668344 -
Flags: review?(jyavenard) → review+
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4174ca0e2b32
https://hg.mozilla.org/mozilla-central/rev/ef11325051ad
https://hg.mozilla.org/mozilla-central/rev/0e575a81a5f5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•