Closed
Bug 1210077
Opened 9 years ago
Closed 9 years ago
HttpChannelChild::ResetInterception needs to check to see if gNeckoChild is null before calling ContinueAsyncOpen
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: khuey, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mcmanus
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Otherwise we crash. I saw this when shutting down a browser that was in the middle of doing service workery things, and AsyncOpen already null checks gNeckoChild.
|
||
Updated•9 years ago
|
Blocks: ServiceWorkers-v1
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ehsan
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8671051 -
Flags: review?(mcmanus)
|
||
Updated•9 years ago
|
Attachment #8671051 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()
Approval Request Comment
[Feature/regressing bug #]: ServiceWorkers
[User impact if declined]: This fixes a crash which we don't have an STR for.
[Describe test coverage new/current, TreeHerder]: Untested, but obviously gets the job done. :-)
[Risks and why]: Doesn't add any risks to non-SW things.
[String/UUID change made/needed]: None.
Attachment #8671051 -
Flags: approval-mozilla-aurora?
|
||
Comment 4•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8671051 [details] [diff] [review]
Null check gNeckoChild in HttpChannelChild::ResetInterception()
Approved for aurora uplift, fixes a crash in feature aimed at 43
Attachment #8671051 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 6•9 years ago
|
||
status-firefox43:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•