Open Bug 1210318 Opened 9 years ago Updated 2 years ago

[Control Center] Tracking protection text is cut off when exiting full screen

Categories

(Firefox :: Site Identity, defect, P5)

Product:
Firefox
Component:
Site Identity
Platform:
All
Windows 7
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox44 --- affected

People

(Reporter: phorea, Unassigned, Mentored)

Details

(Keywords: polish, Whiteboard: [experience required][lang=c++][see comment 16])

Attachments

(1 file)

text missing.png
(deleted), image/png
Details
Attached image text missing.png (deleted) —
Reproduced with Firefox 42 beta 2, Dev Ed 43.0a2 and Nightly 44.0a1 2015-09-30 under Win 7 32-bit. STR: 1. Open a private window 2. Go to https://www.mozilla.org/ 3. Enter fullscreen 4. Select the Control Center doorhanger 5. Exit fullscreen ER: Text is correctly displayed AR: Text is not wrapped, it overlaps the panel when exiting full screen This also happens for Permissions area. Note: This doesn't reproduce under Ubuntu 12.04 32-bit and Mac OS X 10.9.5.
Whiteboard: [fxprivacy] → [fxprivacy] [triage]
I cannot reproduce this under Windows 7 64-bit. I used F11 to enter fullscreen and to exit while the panel was open. Are there other variables to take into account or is this a 32-bit specific issue? Maybe the OS theme is relevant? Is this reproducible on another Windows machine?
Flags: needinfo?(petruta.rasa)
(In reply to Petruta Rasa [QA] [:petruta] from comment #0) > Reproduced with Firefox 42 beta 2, Dev Ed 43.0a2 and Nightly 44.0a1 > 2015-09-30 under Win 7 32-bit. Actually, it was a 64-bit system, sorry. (In reply to :Paolo Amadini from comment #1) > Are there other variables to take into account or is this a 32-bit specific > issue? Maybe the OS theme is relevant? Is this reproducible on another > Windows machine? I couldn't reproduce on Win 8 32/64-bit and Win 10 64-bit with default themes. I could reproduce on two Win 7 64-bit machines, both had the default OS theme (Aero) and the issue was gone when switching to Windows Classic theme. Gif with the issue: https://drive.google.com/file/d/0B7jBNZBM3mz-MDJpYzc5LW5vR28/view?usp=sharing
Flags: needinfo?(petruta.rasa)
Whiteboard: [fxprivacy] [triage]
(In reply to Petruta Rasa [QA] [:petruta] from comment #2) > I could reproduce on two Win 7 64-bit machines, both had the default OS > theme (Aero) and the issue was gone when switching to Windows Classic theme. I confirm it happens on Windows 7 with the Aero theme for me as well. I've no idea what could be causing it. We reserve the space for the label, but then don't wrap it anymore after existing fullscreen. It looks like a layout issue to me, I'll needinfo David Baron who is the module owner.
Flags: needinfo?(dbaron)
Hopefully Xidorn can look.
Flags: needinfo?(dbaron) → needinfo?(quanxunzhen)
Summary: [Control Center] Tracking protection text is cut when exiting full scren → [Control Center] Tracking protection text is cut off when exiting full screen
Hmmm, it sounds like some XUL layout issue. Since it is only reproducible in a very specific platform (Win7 Aero), I wonder there is some widget code kicks in, e.g. the panel window is resized forth and back in a moment unexpectedly. Because I don't have such platform on hand, I myself cannot reproduce this issue. Probably I should ni? some windows widget guy for this. BTW, there is some possibly-related XUL code lands recently, could you test whether this issue is still there?
Flags: needinfo?(quanxunzhen)
Flags: needinfo?(petruta.rasa)
I can still see it with Nightly 44.0a1 2015-10-11. It is reproducible also when pressing F11 while in normal window mode with the panel opened.
Flags: needinfo?(petruta.rasa)
Thanks. We spoke about this in standup with MattN and Elan. I'm going to NI :jimm to see what he thinks. We're less worried about this specific edge case and more worried generally about impacted doorhangers and layouts across the UI when going between full screen and normal mode. We believe that any broken layouts would persist until browser restart.
Flags: needinfo?(jmathies)
Removing this bug as a blocker for the TP UItour.
No longer blocks: 1178805
I see Move get called on the widget, which triggers a few native related events. The native window doesn't experience much of a change othe than this. I'd guess the cause probably has something to do with caching of values somewhere that don't get refreshed in time. The good news is it goes away as soon as the panel hides and is reshown, so it's not permanent.
Mentor: jmathies
Flags: needinfo?(jmathies)
Keywords: polish
Whiteboard: [good first bug][lang=c++]
Hi, my name is Mukhtar Ali and I am currently studying Open-Source Development at Coventry University. For my first bug, I would like to be assigned to this task.
Hello, I am a beginner to open source development. It would be great if I could get the opportunity to take up this task
Comment on attachment 8668313 [details] text missing.png Hi Please could you reply to my request to be assinged this bug. Thanks in advance.
Flags: needinfo?(petruta.rasa)
It seems you'd like to mentor this bug. There are several people asked to help on this bug above, probably you could mentor one of them to fix this?
Flags: needinfo?(jmathies)
(In reply to owosenitobi from comment #12) > Hi Please could you reply to my request to be assinged this bug. > Thanks in advance. I only reported this bug, Jim will assist in mentoring.
Flags: needinfo?(petruta.rasa)
I want to work on this bug, can you please assign this bug to me.
(In reply to S KARTHIK SRIRAM from comment #15) > I want to work on this bug, can you please assign this bug to me. Hi kartik, We'd like to investigate whether or not xidorn's hypothesis in comment 5 is correct. What we'd need to do is add some logging down in the widget area of our Windows code base that manages window size [1]. From that we want to try to identify the individual panel window in question and look for odd resizing behavior while entering/leaving fullscreen in the browser. [1] https://dxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#6717
Flags: needinfo?(jmathies)
Move control center bugs, filter on "de-generalize-control-center"
Component: General → Site Identity and Permission Panels
Priority: -- → P5

Can I also try this one?

I'm not sure, can we still consider this a good first bug, Jim?

Flags: needinfo?(jmathies)

(In reply to Johann Hofmann [:johannh] from comment #19)

I'm not sure, can we still consider this a good first bug, Jim?

Don't see why not, this is so corner case we'll likely never get to it.

Flags: needinfo?(jmathies)
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][see comment 16]

To be fair, after reviewing the criteria at...

https://wiki.mozilla.org/Contribute/Coding/Mentoring

...this is closer to the Experience Required category: "generally corner-case bugs that live on the ragged edges between two different pieces of technology - JS and C++ on a specific architecture".

That said, if Jim is available to mentor the debugging stage, then definitely people should feel free to give it a try, but this may be more complex than the average good first bug for someone who has never contributed before.

Just to clarify, this bug needs a full C++ (not artifact) build on a Windows 7 machine. This isn't solvable using Windows 8, Windows 10, Mac, or Linux. Please make sure you have the required hardware and software before applying!

Whiteboard: [good first bug][lang=c++][see comment 16] → [experience required][lang=c++][see comment 16]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: