See https://bugzilla.mozilla.org/show_bug.cgi?id=1204570#c4, an error is thrown when trying to open the doorhanger. STR: Set devtools.devedition.promo.enabled = true devtools.devedition.promo.shown = false Open Toolbox Expected: Doorhanger opens Actual: Nothing happens

Seeing in Nightly Fx44 as well -- does `const { Promise } = require("promise")` no longer work? Something with the migration?

Bug 1210430 - Use global Promise to make beta doorhanger work again;r=jsantell

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #1) > Seeing in Nightly Fx44 as well -- does `const { Promise } = > require("promise")` no longer work? Something with the migration? I believe I've seen this even in DE 42 (and it might be an issue on Beta as well, I haven't checked yet). Seems like a casing issue maybe (like it's wanting lowercase 'p' promise to be exported there)?

Just confirmed this isn't an issue on beta 42

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #1) > Seeing in Nightly Fx44 as well -- does `const { Promise } = > require("promise")` no longer work? Something with the migration? It definitely should work... I am very confused now.

Alex did a mass-replace in 43, but this file was not updated correctly[1]: 1.12 -const { Promise } = require("resource://gre/modules/Promise.jsm"); 1.13 +const { Promise } = require("promise"); require("promise") is already destructured. We may want to check in case this happened elsewhere... [1]: https://hg.mozilla.org/mozilla-central/diff/dffe88885c1b/browser/devtools/shared/doorhanger.js

Comment on attachment 8668503 [details] MozReview Request: Bug 1210430 - Use Promise.jsm to make beta doorhanger work again;r=jsantell https://reviewboard.mozilla.org/r/20973/#review18857

A quick search suggests this is only affected file. Anyway, either fix is fine, you could take the attached approach, or fix up require("promise"). Native promise loses some debug info though. [Tracking Requested - why for this release]: Let's make sure we uplift to 43.

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8) > A quick search suggests this is only affected file. > > Anyway, either fix is fine, you could take the attached approach, or fix up > require("promise"). Native promise loses some debug info though. > > [Tracking Requested - why for this release]: Let's make sure we uplift to 43. Going to switch to the fix in Comment 6 since it affects less LOC

Comment on attachment 8668503 [details] MozReview Request: Bug 1210430 - Use Promise.jsm to make beta doorhanger work again;r=jsantell Bug 1210430 - Use Promise.jsm to make beta doorhanger work again;r=jsantell

Tracking since this is a regression. Please request uplift and we can get this into aurora :)

Comment on attachment 8668503 [details] MozReview Request: Bug 1210430 - Use Promise.jsm to make beta doorhanger work again;r=jsantell Approval Request Comment [Feature/regressing bug #]: 1193313 [User impact if declined]: Beta doorhanger promoting DevEdition won't open [Describe test coverage new/current, TreeHerder]: None/none [Risks and why]: Low risk, changing the path of an imported promise library [String/UUID change made/needed]:

Comment on attachment 8668503 [details] MozReview Request: Bug 1210430 - Use Promise.jsm to make beta doorhanger work again;r=jsantell Fix for recent regression; please uplift to aurora.

* Navigated to about:config * Set devtools.devedition.promo.enabled = true devtools.devedition.promo.shown = false * Opened new tab * Option-clicked "Inspect Element" * Saw "doorhanger" (see attached) * Opened another new tab * Option-clicked "Inspect Element" * Did not see "doorhanger" * Inspected about:config * Observed devtools.devedition.promo.enabled = true devtools.devedition.promo.shown = true * Set devtools.devedition.promo.enabled = false devtools.devedition.promo.shown = false * Opened another new tab * Option-clicked "Inspect Element" * Did not see "doorhanger"

Attaching screenshot of verification on 45 Nightly (MacOS).

Reverting status to Resolved per discussion with lizzard.

I have reproduced the bug in Nightly 44.0a1 (2015-10-01)(Build ID:20151001030236) with the instruction from comment 0 and linux lite 32 bit Bug is fixed now on Latest Developer Edition 44.0a2 (2015-12-02)(Build ID:20151202004004) User Agent : Mozilla/5.0 (X11; Linux i686; rv:44.0) Gecko/20100101 Firefox/44.0 [bugday-20151202]

Reproduced the bug in Nightly 44.0a1 (Build ID: 20151001030236; User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0) with the instruction from comment 0 with windows 8.1 64bit Fixed on latest Developer Edition 44.0a2 (Build ID: 20151202004004; User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0) As per comment 21 the bug is also verified fixed on linux; changing status form RESOLVED FIXED to VERIFIED FIXED.