Fischer [:Fischer] Assignee
	Description • 9 years ago

Fling player control panel should
(1) Hide automatically
(2) Show when user presses remote control's key

	Evelyn Hung
	Comment 3 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

It seems you didn't add too much features in this patch but split codes into some small files which I'm not sure if it's worth doing. 

As we discussed offline, we can't workaround Gecko issues in Gaia just for easier doing manual test, instead we should push Gecko guys to fix them and list them as your blockers if they really block your development.

Please also try new mozIntl api to your time formatting case as Zibi suggested in the mail. Thanks.

	Fischer [:Fischer] Assignee
	Comment 4 • 9 years ago

Please see the updated PR: https://github.com/mozilla-b2g/gaia/pull/32290
Because the mozIntl formats based on locale and my format case should disregard locale, would just leave the mozIntl there.

	Evelyn Hung
	Comment 5 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

Luke, could you feedback on the change of simple_key_navigation.js? Thanks!

	Fischer [:Fischer] Assignee
	Comment 6 • 9 years ago

@Zibi
My case is that the current video time(hh:mm:ss) and the video total duration(hh:mm:ss) are placed on the two sides of time progress bar.
Since the control panel of my TV video player has no text but just icon, time bar and time digits(in hh:mm:ss), I am not sure my case fit the mozIntl.DurationFormat use case.
Could you please elaborate more about the mozIntl.DurationFormat use case ?

	Evelyn Hung
	Comment 7 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

Just a few nits need to be addressed, please see my comments on Github.
I'd like to know Zibi's opinion on the playback time. I guess we need to localize it. Thanks.

	Fischer [:Fischer] Assignee
	Comment 8 • 9 years ago

@Zibi,
My case is that the current video time(hh:mm:ss) and the video total duration(hh:mm:ss) are placed on the two sides of time progress bar.
Since the control panel of my TV video player has no text but just icon, time bar and time digits(in hh:mm:ss), I am not sure my case fit the mozIntl.DurationFormat use case.
Could you please elaborate more about the mozIntl.DurationFormat use case ?

	Luke Chang [:lchang] (inactive)
	Comment 9 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

I left some comments on "simple_key_navigation.js". Please take a look. Thanks.

	Luke Chang [:lchang] (inactive)
	Comment 10 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

"simple_key_navigation.js" looks good to me. Thanks.

	Evelyn Hung
	Comment 11 • 9 years ago

Comment on attachment 8670699 [details]
PR #32290

r+ with nits addressed. Please file a follow-up bug for mozIntl thing. Thanks.

	Fischer [:Fischer] Assignee
	Comment 12 • 9 years ago

Land to master: https://github.com/mozilla-b2g/gaia/pull/32290
Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1a1c447e4516ca77b90569ccd6eab51a9b8f8c25