Closed Bug 1210707 Opened 9 years ago Closed 9 years ago

Feedback view no longer allows closing the window and avoiding leaving feedback

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
1

Tracking

(firefox42 unaffected, firefox43+ fixed, firefox44+ fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Iteration:
44.2 - Oct 19
Tracking Flags:
Tracking Status
firefox42 --- unaffected
firefox43 + fixed
firefox44 + fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

Feedback view no longer allows closing the window and avoiding leaving feedback.
(deleted), patch
mikedeboer
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review
STR: 1) With a fresh profile, or with loop.feedback.dateLastSeenSec cleared, start a two-way conversation. 2) Exit the conversation on the desktop client. => Feedback view is shown. 3) Click the leave button again to avoid leaving feedback Actual Results => Nothing happens Expected Results => The conversation window is closed.
Assignee: nobody → standard8
Rank: 21
We missed a case, thankfully the fix is quite simple.
Attachment #8669582 - Flags: review?(mdeboer)
Iteration: --- → 44.1 - Oct 5
Points: --- → 1
Comment on attachment 8669582 [details] [diff] [review] Feedback view no longer allows closing the window and avoiding leaving feedback. Review of attachment 8669582 [details] [diff] [review]: ----------------------------------------------------------------- Ah, thanks! And a test - me gusta! :)
Attachment #8669582 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/be2e4d37fbc2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1184921
No longer blocks: 1184559
Comment on attachment 8669582 [details] [diff] [review] Feedback view no longer allows closing the window and avoiding leaving feedback. Approval Request Comment [Feature/regressing bug #]: Bug 1184921 (approval reqd for 43) [User impact if declined]: The user won't be able to close the conversation window when the feedback request is displayed, unless they select the leave feedback option. [Describe test coverage new/current, TreeHerder]: Landed in m-c with unit tests. [Risks and why]: Low, handles a missing case. [String/UUID change made/needed]: None
Attachment #8669582 - Flags: approval-mozilla-aurora?
Comment on attachment 8669582 [details] [diff] [review] Feedback view no longer allows closing the window and avoiding leaving feedback. Fixes recent regression, needs to uplift to aurora along with 1184921
Attachment #8669582 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Iteration: 44.1 - Oct 5 → 44.2 - Oct 19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: