Closed
Bug 1211005
Opened 9 years ago
Closed 6 years ago
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird51 fixed)
RESOLVED
FIXED
Thunderbird 51.0
Tracking | Status | |
---|---|---|
thunderbird51 | --- | fixed |
People
(Reporter: rkent, Assigned: aceman)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-aurora+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•9 years ago
|
||
Linux debug
15:27:52 INFO - SUMMARY-UNEXPECTED-FAIL | test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline
15:27:52 INFO - EXCEPTION: Timed out: Notification existed and did not disappear.
15:27:52 INFO - at: utils.js line 447
15:27:52 INFO - TimeoutError utils.js:447 13
15:27:52 INFO - waitFor utils.js:485 11
15:27:52 INFO - MozMillController.prototype.waitFor controller.js:687 3
15:27:52 INFO - test_crashed_plugin_notification_inline test-plugin-crashing.js:241 5
15:27:52 INFO - Runner.prototype.wrapper frame.js:585 9
15:27:52 INFO - Runner.prototype._runTestModule frame.js:655 9
15:27:52 INFO - Runner.prototype.runTestModule frame.js:701 3
15:27:52 INFO - Runner.prototype.runTestDirectory frame.js:525 7
15:27:52 INFO - runTestDirectory frame.js:707 3
15:27:52 INFO - Bridge.prototype._execFunction server.js:179 10
15:27:52 INFO - Bridge.prototype.execFunction server.js:183 16
15:27:52 INFO - Session.prototype.receive server.js:283 3
15:27:52 INFO - AsyncRead.prototype.onDataAvailable server.js:88 3
Yes, I did some notifications that had to be waited for. But non-disappearing notifications seems a bit different problem.
Flags: needinfo?(acelists)
Comment 4•8 years ago
|
||
14:56:35 INFO - TEST-START | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | setupTest
14:56:35 INFO - ++DOCSHELL 0x91592c00 == 13 [pid = 4821] [id = 14]
14:56:35 INFO - ++DOMWINDOW == 35 (0x91593c00) [pid = 4821] [serial = 35] [outer = (nil)]
14:56:35 INFO - ++DOMWINDOW == 36 (0x91651c00) [pid = 4821] [serial = 36] [outer = 0x91593c00]
14:56:35 INFO - ++DOMWINDOW == 37 (0x914bf000) [pid = 4821] [serial = 37] [outer = 0x99ffe400]
14:56:35 INFO - ++DOMWINDOW == 38 (0x9180a800) [pid = 4821] [serial = 38] [outer = 0x91593c00]
14:56:35 INFO - For application/x-test found plugin libnptest.so
14:56:35 INFO - Xlib: extension "RANDR" missing on display ":0".
14:56:35 INFO - LoadPlugin() /builds/slave/test/build/application/thunderbird/plugins/libnptest.so returned ab809120
14:56:35 INFO - [NPAPI 4884] WARNING: '!compMgr', file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 63
14:56:35 INFO - [NPAPI 4884] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/modules/libpref/Preferences.cpp, line 1386
14:56:35 INFO - [NPAPI 4884] WARNING: '!compMgr', file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 63
14:56:35 INFO - [NPAPI 4884] WARNING: '!compMgr', file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/xpcom/glue/nsComponentManagerUtils.cpp, line 63
14:56:36 INFO - TEST-PASS | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | test-plugin-crashing.js::setupTest
14:56:36 INFO - TEST-START | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | test_crashed_plugin_notification_inline
14:56:36 INFO - ###!!! [Parent][MessageChannel::Call] Error: Channel error: cannot send/recv
14:56:36 INFO - [4821] WARNING: Failed to send message!: file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/dom/plugins/ipc/PluginScriptableObjectParent.cpp, line 265
14:56:36 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel error: cannot send/recv
14:56:36 INFO - [4821] WARNING: '!aObserver', file /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/xpcom/ds/nsObserverService.cpp, line 258
14:56:37 INFO - --DOMWINDOW == 37 (0x90970c00) [pid = 4821] [serial = 28] [outer = (nil)] [url = http://localhost:43336/plugin.html]
14:56:39 INFO - --DOCSHELL 0x9159a400 == 12 [pid = 4821] [id = 13]
14:56:39 INFO - --DOMWINDOW == 36 (0x904e0000) [pid = 4821] [serial = 30] [outer = (nil)] [url = http://localhost:43336/plugin.html]
14:56:39 INFO - --DOMWINDOW == 35 (0x90974000) [pid = 4821] [serial = 29] [outer = (nil)] [url = about:blank]
14:56:39 INFO - --DOMWINDOW == 34 (0x980f0c00) [pid = 4821] [serial = 26] [outer = (nil)] [url = chrome://messenger/content/msgAccountCentral.xul]
14:56:39 INFO - --DOMWINDOW == 33 (0x93057800) [pid = 4821] [serial = 17] [outer = (nil)] [url = about:blank]
14:56:39 INFO - --DOMWINDOW == 32 (0x97ac4c00) [pid = 4821] [serial = 15] [outer = (nil)] [url = about:blank]
14:56:39 INFO - --DOMWINDOW == 31 (0x97668800) [pid = 4821] [serial = 16] [outer = (nil)] [url = about:blank]
14:56:40 INFO - --DOMWINDOW == 30 (0x9159d800) [pid = 4821] [serial = 32] [outer = (nil)] [url = about:blank]
14:56:40 INFO - --DOMWINDOW == 29 (0xa740f400) [pid = 4821] [serial = 2] [outer = (nil)] [url = about:blank]
14:56:40 INFO - --DOMWINDOW == 28 (0x97888400) [pid = 4821] [serial = 27] [outer = (nil)] [url = chrome://messenger/content/msgAccountCentral.xul]
14:56:42 INFO - TEST-START | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | teardownTest
14:56:42 INFO - TEST-PASS | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | test-plugin-crashing.js::teardownTest
14:56:42 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline
These days the test is failing a line above at:
03:51:20 INFO - SUMMARY-UNEXPECTED-FAIL | test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline
03:51:20 INFO - EXCEPTION: submitDiv is null
03:51:20 INFO - at: test-plugin-crashing.js line 233
03:51:20 INFO - test_crashed_plugin_notification_inline test-plugin-crashing.js:233 7
03:51:20 INFO - Runner.prototype.wrapper frame.js:585 9
03:51:20 INFO - Runner.prototype._runTestModule frame.js:655 9
03:51:20 INFO - Runner.prototype.runTestModule frame.js:701 3
03:51:20 INFO - Runner.prototype.runTestDirectory frame.js:525 7
03:51:20 INFO - runTestDirectory frame.js:707 3
03:51:20 INFO - Bridge.prototype._execFunction server.js:179 10
03:51:20 INFO - Bridge.prototype.execFunction server.js:183 16
03:51:20 INFO - Session.prototype.receive server.js:283 3
03:51:20 INFO - AsyncRead.prototype.onDataAvailable server.js:88 3
I've seen it right now on my machine, let's try some experiments:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cba6ea3fd1ab0e9a79b01d180a66231ff3d2b162
Nice, so after that patch experiment, the original message reappeared :)
23:41:36 INFO - SUMMARY-UNEXPECTED-FAIL | test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline
23:41:36 INFO - EXCEPTION: Timed out: Notification existed and did not disappear.
23:41:36 INFO - at: utils.js line 447
23:41:36 INFO - TimeoutError utils.js:447 13
23:41:36 INFO - waitFor utils.js:485 11
23:41:36 INFO - MozMillController.prototype.waitFor controller.js:687 3
23:41:36 INFO - test_crashed_plugin_notification_inline test-plugin-crashing.js:245 5
Whenever I pushed this to try, it did have an effect. I can't say it fixes the problem 100%, but it seems to be an improvement.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=aaa8b4d2c09354029d0a2974bb112d0990e72ead
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cb20afe109ee494269bc6658778ad127932ebdd8
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=881dc4b0612d5813f262daef5a0c8db0970581e9
Attachment #8781251 -
Flags: review?(mkmelin+mozilla)
Comment 8•8 years ago
|
||
Comment on attachment 8781251 [details] [diff] [review]
patch
Review of attachment 8781251 [details] [diff] [review]:
-----------------------------------------------------------------
Let's try it. r=mkmelin
Attachment #8781251 -
Flags: review?(mkmelin+mozilla) → review+
Assignee: nobody → acelists
Keywords: checkin-needed
OS: Unspecified → Linux
Hardware: Unspecified → All
Comment 9•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
status-thunderbird51:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
Comment 10•8 years ago
|
||
Comment on attachment 8781251 [details] [diff] [review]
patch
Let's get Aurora and Beta greener as well.
Attachment #8781251 -
Flags: approval-comm-beta+
Attachment #8781251 -
Flags: approval-comm-aurora+
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
Sorry, still fails sometimes, for example here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=7227ccc1a86959db21ee85ccbdfefc1424d0f32b&selectedJob=45916
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 14•6 years ago
|
||
The whole test file was removed in bug 1508942.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•