Closed Bug 1211563 Opened 9 years ago Closed 9 years ago

Invite buttons should be underneath "Invite a friend" text in popped-out view

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

(firefox43 verified, firefox44 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla44
Iteration:
44.2 - Oct 19
Tracking Flags:
Tracking Status
firefox43 --- verified
firefox44 --- verified

People

(Reporter: sevaan, Assigned: Mardak)

References

Details

Attachments

(4 files)

Screenshot of Issue
(deleted), image/png
Details
v1
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
v1 screenshot
(deleted), image/png
sevaan
: ui-review+
Details
for aurora (Mardak will land)
(deleted), patch
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image Screenshot of Issue (deleted) —
When popping out the conversation window, the invitation buttons are separated by too much space from the "Invite a friend to join you" text. The buttons should be underneath the buttons in the same manner of spacing as it looked when the conversation window is docked.
Depends on: 1184924
Attached patch v1 (deleted) — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8669999 - Flags: review?(standard8)
Attached image v1 screenshot (deleted) —
Attachment #8670000 - Flags: ui-review?(sfranks)
Points: --- → 2
Attachment #8670000 - Flags: ui-review?(sfranks) → ui-review+
Comment on attachment 8669999 [details] [diff] [review] v1 Review of attachment 8669999 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=Standard8
Attachment #8669999 - Flags: review?(standard8) → review+
https://hg.mozilla.org/integration/fx-team/rev/5e57563087b61888fb2e1551ab4a3fc4fb2ebecf Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8]
https://hg.mozilla.org/mozilla-central/rev/5e57563087b6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Attached patch for aurora (Mardak will land) (deleted) — — Splinter Review
Approval Request Comment [Feature/regressing bug #]: Hello Visual refresh [User impact if declined]: Buttons can be separated from the related header text on large windows [Describe test coverage new/current, TreeHerder]: N/a, css only [Risks and why]: Low - css only [String/UUID change made/needed]: None I'll land this after bug 1184924 is uplifted.
Comment on attachment 8670939 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment [Feature/regressing bug #]: Hello Visual refresh [User impact if declined]: Buttons can be separated from the related header text on large windows [Describe test coverage new/current, TreeHerder]: N/a, css only [Risks and why]: Low - css only [String/UUID change made/needed]: None I'll land this after bug 1184924 is uplifted.
Attachment #8670939 - Flags: approval-mozilla-aurora?
Iteration: --- → 44.2 - Oct 19
Comment on attachment 8670939 [details] [diff] [review] for aurora (Mardak will land) Minor css tweaks, ok to uplift to aurora
Attachment #8670939 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/eeef206961d3 Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8, a=lizzard]
status-firefox43: --- → fixed
Flags: qe-verify+
QA Contact: bogdan.maris
Verified that the buttons are underneath 'Invite a fiend' string just as shown in attachment using Firefox Developer Edition 43.0a2 and latest Nightly 44.0a1 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
status-firefox43: fixed → verified
status-firefox44: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: