Alice0775 White Reporter
	Description • 9 years ago

[Tracking Requested - why for this release]:

This bug was filed from the Socorro interface and is 
report bp-0ad4d743-a8ff-4097-9932-7836e2151005.
=============================================================

Reported http://forums.mozillazine.org/viewtopic.php?p=14355143#p14355143

STR
Open http://e-fibank.bg

Regression window:
https://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=e843ef367f3535bdb675f6afd501ac8b8d0220d&tochange=27576be038ea

Regressed by:
27576be038ea	Yoshi Huang — Bug 1167100 - User originAttribute in ContentPrincipalInfo. r=bholley

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Assignee
	Comment 1 • 9 years ago

Thanks,
I found the problem is that appId is type of uin32_t from WebIDL, however in CreateSuffix and PopulateFromSuffix, we use nsString.AppendInt and nsString.ToInteger to handle it , which takes *int32_t*, will have a patch and a test case (maybe gtest) for this.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Assignee
	Comment 2 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=02506fd4b8e9

	Bobby Holley (:bholley)
	Comment 3 • 9 years ago

Comment on attachment 8670151 [details] [diff] [review]
Patch. v1

Review of attachment 8670151 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, especially the test!

This is actually the same bug as bug 1203979, but it also handles userContextId which is great. Feel free to dupe that bug to this one.

::: caps/BasePrincipal.cpp
@@ +119,5 @@
>                           const nsString& aValue) override
>    {
>      if (aName.EqualsLiteral("appId")) {
>        nsresult rv;
> +      mOriginAttributes->mAppId = aValue.ToInteger64(&rv);

Please make this:

int64_t val = aValue.ToInteger64(&rv);
NS_ENSURE_SUCCESS(rv, rv);
NS_ENSURE_TRUE(val <= UINT32_MAX, NS_ERROR_FAILURE);
mOriginAttributes->mAppId = static_cast<uint32_t>(val);

Here and below.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Assignee
	Comment 5 • 9 years ago

(In reply to Bobby Holley (:bholley) from comment #3)
Thanks for the review.

> int64_t val = aValue.ToInteger64(&rv);
> NS_ENSURE_SUCCESS(rv, rv);
Will change to NS_ENSURE_SUCCESS(rv, false);
since this function returns bool.

> NS_ENSURE_TRUE(val <= UINT32_MAX, NS_ERROR_FAILURE);
NS_ENSURE_TRUE(val <= UINT32_MAX, false);

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Assignee
	Comment 6 • 9 years ago

addressed bholley's comment.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Assignee
	Comment 7 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69004f72de80

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/f60288aebcc7

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f60288aebcc7

	Rezaul Huque Nayeem
	Comment 10 • 9 years ago

Reproduced the bug in 44.0a1 (2015-10-05) on windows 10 x64

Verified as fixed with latest firefox aurora 44.0a2 (Build ID: 20151210004006)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0

	Camelia Badau [:cbadau], Desktop QA
	Comment 11 • 9 years ago

Based on comment 10 and based on the details from Soccoro where no reports were found in the last 14 days, marking this bug as Verified Fixed.