Closed
Bug 1211642
Opened 9 years ago
Closed 9 years ago
Whitelist test plugin for async init
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox42 wontfix, firefox43 fixed, firefox44 fixed)
RESOLVED
FIXED
mozilla44
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jimm
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
We need to whitelist the test plugin to ensure that async init will be tested adequately.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8673315 -
Flags: review?(jmathies)
Updated•9 years ago
|
Attachment #8673315 -
Flags: review?(jmathies) → review+
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Updated•9 years ago
|
status-firefox42:
--- → affected
status-firefox43:
--- → affected
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8673315 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: async init will be disabled during testing
[Describe test coverage new/current, TreeHerder]: plugin test suite
[Risks and why]: Low, this really only affects testing but does affect xul.dll so I'm requesting approval.
[String/UUID change made/needed]: None
Attachment #8673315 -
Flags: approval-mozilla-beta?
Attachment #8673315 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Comment on attachment 8673315 [details] [diff] [review]
Patch
Taking anything to help testing async plugin init.
Should be in 42 beta 8
Attachment #8673315 -
Flags: approval-mozilla-beta?
Attachment #8673315 -
Flags: approval-mozilla-beta+
Attachment #8673315 -
Flags: approval-mozilla-aurora?
Attachment #8673315 -
Flags: approval-mozilla-aurora+
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Various plugin tests have been failing since this landed on beta:
https://treeherder.mozilla.org/logviewer.html#?job_id=588233&repo=mozilla-beta
https://treeherder.mozilla.org/logviewer.html#?job_id=588229&repo=mozilla-beta
https://treeherder.mozilla.org/logviewer.html#?job_id=588224&repo=mozilla-beta
Backing out to fix them up:
https://hg.mozilla.org/releases/mozilla-beta/rev/bff8b3d98f72
Flags: needinfo?(aklotz)
Comment 9•9 years ago
|
||
Too late for 42 (even more as we disabled async plugin init)
Updated•9 years ago
|
Attachment #8673315 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta-
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #8)
> Various plugin tests have been failing since this landed on beta:
> https://treeherder.mozilla.org/logviewer.html#?job_id=588233&repo=mozilla-
> beta
> https://treeherder.mozilla.org/logviewer.html#?job_id=588229&repo=mozilla-
> beta
> https://treeherder.mozilla.org/logviewer.html#?job_id=588224&repo=mozilla-
> beta
>
>
> Backing out to fix them up:
> https://hg.mozilla.org/releases/mozilla-beta/rev/bff8b3d98f72
That's due to bug 1218473 et al. Will be sorted out with that.
Flags: needinfo?(aklotz)
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•