Closed Bug 1211716 Opened 9 years ago Closed 9 years ago

Duplicated shared theme entries in jar.mn

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox44 --- affected
firefox48 --- fixed

People

(Reporter: Dolske, Assigned: englehardt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1191442 landed after the jar.mn cleanup in bug 1204182 and bug 1191442. Please move these lines: skin/classic/browser/usercontext/personal.svg (../shared/usercontext/personal.svg) skin/classic/browser/usercontext/work.svg (../shared/usercontext/work.svg) skin/classic/browser/usercontext/banking.svg (../shared/usercontext/banking.svg) skin/classic/browser/usercontext/shopping.svg (../shared/usercontext/shopping.svg) From browser/theme/*/jar.mn to browser/theme/shared/jar.inc.mn.
(In reply to Justin Dolske [:Dolske] from comment #0) > cleanup in bug 1204182 and bug 1191442. Oops, that should be "bug 1204182 and bug 1206883".
Steven, are you currently working on this?
Flags: needinfo?(bugzilla)
Thanks for the ping Gijs. It's a quick fix, so I'll be able to post a patch shortly.
Flags: needinfo?(bugzilla)
Attached patch 1211716.patch (deleted) — Splinter Review
Attachment #8728224 - Flags: review?(paolo.mozmail)
Comment on attachment 8728224 [details] [diff] [review] 1211716.patch Review of attachment 8728224 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this review - looks good to me, thanks!
Attachment #8728224 - Flags: review?(paolo.mozmail) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: