Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Description • 9 years ago

As requested, this is preferable since otherwise you need to load a library to get this function.

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 1 • 9 years ago

Patch to implement this.

This shows up some more failures on armsim builds which I'm investigating.

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 2 • 9 years ago

Patch to reimplement oomTest() as a shell function.  It should be more deterministic like this too.

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 3 • 9 years ago

Patch to fix a couple of issues that started showing up with the previous patch.

The first is that compilerOutputs vector in the TypeZone can end up with containing a script that we failed to link if we get an OOM after FinishCompilation() in LazyLink().  This causes an assert on subsequent calls to LazyLink() for the same script.

The second is that IonCompile() could leave a script's ionScript set to ION_COMPILING_SCRIPT if StartOffThreadIonCompile() failed.

	Jan de Mooij [:jandem]
	Comment 4 • 9 years ago

Comment on attachment 8671927 [details] [diff] [review]
ion-fixes-for-shell-oomTest

Review of attachment 8671927 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.cpp
@@ -2207,5 @@
>  
>      // If possible, compile the script off thread.
>      if (options.offThreadCompilationAvailable()) {
> -        if (!recompile)
> -            builderScript->setIonScript(cx, ION_COMPILING_SCRIPT);

Hannes fixed this one in another bug so it may already be on inbound when this lands.

	Nicolas B. Pierron [:nbp]
	Comment 5 • 9 years ago

Comment on attachment 8671924 [details] [diff] [review]
bug1212469-shell-oomTest v2

Review of attachment 8671924 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TestingFunctions.cpp
@@ +56,5 @@
>  static bool
> +EnvVarIsDefined(const char* name)
> +{
> +    const char* value = getenv(name);
> +    return value && value[0] != '0';

nit: && !*value

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c365490d4ce
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cd97a3b2e6

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/9c365490d4ce
https://hg.mozilla.org/mozilla-central/rev/46cd97a3b2e6