Redesign add-on manager inline options flow
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Tracking
()
People
(Reporter: callahad, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, DevAdvocacy, Whiteboard: [options]triaged[DevRel:P2])
Attachments
(2 files)
(deleted),
image/png
|
rfeeley
:
ui-review+
|
Details |
(deleted),
image/gif
|
Details |
Updated•9 years ago
|
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
Updated•9 years ago
|
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
Comment 14•9 years ago
|
||
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Updated•6 years ago
|
Comment 17•6 years ago
|
||
Ping ddurst to consider this again as part of the about:addons rewrite.
Note that we have a ton of open bugs on inline options pages (from a very quick search, at least bug 1420606, bug 1490865, bug 1398481, bug 1402627, bug 1398466, bug 1430648, bug 1418617). I suspect a bunch of these are inherent in having a remote options page framed inside about:addons so just switching to a modal won't immediately solve them.
If we haven't totally abandoned the philosophy of "great or dead", perhaps we'd be better off just always putting options pages into a tab.
Comment 18•6 years ago
|
||
Whoops, the last bug from the list in comment 17 isn't about inline options pages but add bug 1542794 to the list.
Comment 19•6 years ago
|
||
(In reply to Andrew Swan [:aswan] from comment #17)
If we haven't totally abandoned the philosophy of "great or dead", perhaps we'd be better off just always putting options pages into a tab.
I don't think that's a good idea. Even if we didn't care about the UX aspects, most of the bugs relating to inline options also apply to things like browser action popups and sidebars, which we definitely need to keep. And the general problems with OOP iframes need to be deal with for Fission no matter what we do here.
The remaining layout bugs shouldn't be a problem for the modal popup flow.
Comment 20•6 years ago
|
||
And several of those bugs only have to do with the browser_style CSS, which doesn't have anything to do with the options page being embedded.
Comment 21•5 years ago
|
||
Now not XUL, do we re-visit the modal overlay conversation at the beginning of this thread?
Updated•5 years ago
|
Updated•2 years ago
|
Description
•