Closed
Bug 121299
Opened 23 years ago
Closed 23 years ago
Need cookie icon for status bar
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: morse, Assigned: mscott)
References
Details
(Keywords: icon, Whiteboard: icon [adt1 rtm])
Attachments
(4 files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
patch
|
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
dbaron
:
approval+
|
Details | Diff | Splinter Review |
We need to have a status-bar cookie icon, and have it included in cvs and in the
build. See bug 121161 for details of why and where we need this icon.
Reporter | ||
Comment 1•23 years ago
|
||
Marlon,
I have created a temporary icon in the patch for bug 121161. Can you provide us
with a better one or should be go with that one?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Reporter | ||
Comment 2•23 years ago
|
||
Temporary icon has been checked in. Reassigning to Marlon if he wants to
produce a better one. Otherwise close this out and we go with my icon.
Assignee: morse → marlon
Status: ASSIGNED → NEW
Comment 3•23 years ago
|
||
mmmm, cookie icons. accepting
Status: NEW → ASSIGNED
Whiteboard: icon
Target Milestone: mozilla0.9.9 → mozilla1.0
Comment 4•23 years ago
|
||
Would this icon solve Bug 113092
Reporter | ||
Comment 5•23 years ago
|
||
No it wouldn't. The cookie icon here is to indicate if a cookie decision has
been made based on a p3p setting. Bug 113092 is asking for an indicator if a
cookie has been set. So, unless the spec is changed, these are two different
things.
Updated•23 years ago
|
Whiteboard: icon → icon [adt1]
Comment 7•23 years ago
|
||
adding self to cc list
Comment 8•23 years ago
|
||
what we have now should suffice for beta. there will definitely be final icon
coming for RTM (still possibility for getting it done in beta, but no guarantee)
Comment 9•23 years ago
|
||
adding [adt1 rtm] based on Marlon's comments. We'd ship beta with the current icon.
Whiteboard: icon [adt1] → icon [adt1 rtm]
Comment 10•23 years ago
|
||
Here are transparent icons - one for each skin.
Modern: 16px W x 13 px H
filename: cookyM.gif
Classic: 16px W x 12px H
filename: cookyC.gif
Assignee | ||
Comment 11•23 years ago
|
||
I know Steve has much bigger fish to fry so I put together a patch to add the
cookie icons Gail kindly provided onto the trunk.
Attaching a screen shot next showing the new icons.
Assignee | ||
Comment 12•23 years ago
|
||
Reporter | ||
Comment 13•23 years ago
|
||
Looks good to me. r=morse
Assignee | ||
Comment 14•23 years ago
|
||
Thanks Steve. Acceping this bug. I'll try to get it in tonight.
Assignee: marlon → mscott
Status: ASSIGNED → NEW
Comment 15•23 years ago
|
||
Comment on attachment 81062 [details] [diff] [review]
TRUNK patch to use the new icons provided by UE
sr=sspitzer
Attachment #81062 -
Flags: superreview+
Assignee | ||
Comment 16•23 years ago
|
||
This is now fixed on the TRUNK.
If Marlon has a new image tomorrow which he wants to use instead, it becomes
extremely easy to use that icon.
I'll post a much simpler patch for the branch which just replaces the existing
icon in content instead of creating a skins directory with separate classic and
modern icons.
We'll also want to file a spin off bug for the screen shot image which you see
when you click on the icon.
Marking this fixed.
Assignee | ||
Comment 17•23 years ago
|
||
This patch would be for the moz 1.0 branch. It is even less complex than the
trunk patch. It just replaces the existing gif with the new gif.
Assignee | ||
Comment 18•23 years ago
|
||
I also checked in a new image for the image of the cookie status notification
that shows up in the p3p dialog.
Comment 19•23 years ago
|
||
adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check
this in tonight (if possible), then add the fixed1.0.0 keyword. thanks!
Comment 20•23 years ago
|
||
Comment on attachment 81069 [details] [diff] [review]
simplified moz 1.0 BRANCH fix
a=dbaron for 1.0 branch checkin (as if I could tell anything from the patch)
Attachment #81069 -
Flags: approval+
Assignee | ||
Comment 21•23 years ago
|
||
Ok, the simplified fix is now in the 1.0 branch.
Here's what we've got:
TRUNK:
1) New cookie icons for modern AND classic
2) New cookie screen shot icon (for the manager dialog) for modern AND classic
BRANCH:
1) New cookie icon shared by both modern and classic
2) New cookie screen shot icon (for the manager dialog) shared by both modern
and classic.
Marking this as fixed on the branch.
Keywords: adt1.0.0+ → fixed1.0.0
Assignee | ||
Comment 22•23 years ago
|
||
One last thing:
TRUNK:
1) Image referenced by the help files were changed to point to the new images
BRANCH
1) No changes were made to the help documentation so they'll still use the old
image with the white background.
Comment 23•23 years ago
|
||
Speaking as a skin designer, I do hate it when people use skin URLs in content,
is there any chance you can change this to use CSS rules in the skin instead?
Assignee | ||
Comment 24•23 years ago
|
||
*** Bug 140105 has been marked as a duplicate of this bug. ***
Comment 25•22 years ago
|
||
verified both trunk and branch, 05/28/02 winNT4, linux rh6, mac osX
Status: RESOLVED → VERIFIED
Keywords: verified1.0.0
Reporter | ||
Comment 26•22 years ago
|
||
New icon checked in on both branch and trunk at lorikaplan's request
Keywords: fixed1.0.0
You need to log in
before you can comment on or make changes to this bug.
Description
•