Closed Bug 121299 Opened 23 years ago Closed 23 years ago

Need cookie icon for status bar

Categories

(Core :: Networking: Cookies, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.0

People

(Reporter: morse, Assigned: mscott)

References

Details

(Keywords: icon, Whiteboard: icon [adt1 rtm])

Attachments

(4 files)

We need to have a status-bar cookie icon, and have it included in cvs and in the build. See bug 121161 for details of why and where we need this icon.
Keywords: icon
Marlon, I have created a temporary icon in the patch for bug 121161. Can you provide us with a better one or should be go with that one?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Temporary icon has been checked in. Reassigning to Marlon if he wants to produce a better one. Otherwise close this out and we go with my icon.
Assignee: morse → marlon
Status: ASSIGNED → NEW
mmmm, cookie icons. accepting
Status: NEW → ASSIGNED
Whiteboard: icon
Target Milestone: mozilla0.9.9 → mozilla1.0
Keywords: nsbeta1
Would this icon solve Bug 113092
No it wouldn't. The cookie icon here is to indicate if a cookie decision has been made based on a p3p setting. Bug 113092 is asking for an indicator if a cookie has been set. So, unless the spec is changed, these are two different things.
approving. Needed for release.
Keywords: nsbeta1nsbeta1+
Whiteboard: icon → icon [adt1]
adding self to cc list
what we have now should suffice for beta. there will definitely be final icon coming for RTM (still possibility for getting it done in beta, but no guarantee)
adding [adt1 rtm] based on Marlon's comments. We'd ship beta with the current icon.
Whiteboard: icon [adt1] → icon [adt1 rtm]
Here are transparent icons - one for each skin. Modern: 16px W x 13 px H filename: cookyM.gif Classic: 16px W x 12px H filename: cookyC.gif
I know Steve has much bigger fish to fry so I put together a patch to add the cookie icons Gail kindly provided onto the trunk. Attaching a screen shot next showing the new icons.
Looks good to me. r=morse
Thanks Steve. Acceping this bug. I'll try to get it in tonight.
Assignee: marlon → mscott
Status: ASSIGNED → NEW
Comment on attachment 81062 [details] [diff] [review] TRUNK patch to use the new icons provided by UE sr=sspitzer
Attachment #81062 - Flags: superreview+
This is now fixed on the TRUNK. If Marlon has a new image tomorrow which he wants to use instead, it becomes extremely easy to use that icon. I'll post a much simpler patch for the branch which just replaces the existing icon in content instead of creating a skins directory with separate classic and modern icons. We'll also want to file a spin off bug for the screen shot image which you see when you click on the icon. Marking this fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED
Attached patch simplified moz 1.0 BRANCH fix (deleted) — Splinter Review
This patch would be for the moz 1.0 branch. It is even less complex than the trunk patch. It just replaces the existing gif with the new gif.
I also checked in a new image for the image of the cookie status notification that shows up in the p3p dialog.
adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check this in tonight (if possible), then add the fixed1.0.0 keyword. thanks!
Keywords: adt1.0.0adt1.0.0+
Comment on attachment 81069 [details] [diff] [review] simplified moz 1.0 BRANCH fix a=dbaron for 1.0 branch checkin (as if I could tell anything from the patch)
Attachment #81069 - Flags: approval+
Ok, the simplified fix is now in the 1.0 branch. Here's what we've got: TRUNK: 1) New cookie icons for modern AND classic 2) New cookie screen shot icon (for the manager dialog) for modern AND classic BRANCH: 1) New cookie icon shared by both modern and classic 2) New cookie screen shot icon (for the manager dialog) shared by both modern and classic. Marking this as fixed on the branch.
Keywords: adt1.0.0+fixed1.0.0
One last thing: TRUNK: 1) Image referenced by the help files were changed to point to the new images BRANCH 1) No changes were made to the help documentation so they'll still use the old image with the white background.
Speaking as a skin designer, I do hate it when people use skin URLs in content, is there any chance you can change this to use CSS rules in the skin instead?
*** Bug 140105 has been marked as a duplicate of this bug. ***
verified both trunk and branch, 05/28/02 winNT4, linux rh6, mac osX
Status: RESOLVED → VERIFIED
Keywords: verified1.0.0
New icon checked in on both branch and trunk at lorikaplan's request
Keywords: fixed1.0.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: