Do we have a meta bug about improving top sites? I think that we should think about excluding history items that have only been visited once, since they are, by definition, not sites you visit often. In particular, including these items quickly pollute top sites for new users, replacing our nice thumbnails with potentially ugly ones (another issue, but one that's harder to fix).

How do we deal with first time users? They won't see any top sites until they visit a site twice?

Filed bug 1213140

(In reply to Kevin Brosnan [:kbrosnan] from comment #1) > How do we deal with first time users? They won't see any top sites until > they visit a site twice? Yes, that's exactly my hope. Or perhaps we should change my suggestion to be more like "prioritize suggested sites over history items that have only been visited once", so that those history items will end up appearing in thumbnails below our nice-looking suggested sites. I bet this is probably how this originally worked, when those default thumbnails were bookmarks, but implementing suggested sites changed that.

Sounds like this bug is really about improving the "first run" session for Top Sites. After a few days, a "one-visit" site would not affect Top Sites. (In reply to :Margaret Leibovic from comment #3) > (In reply to Kevin Brosnan [:kbrosnan] from comment #1) > > How do we deal with first time users? They won't see any top sites until > > they visit a site twice? > > Yes, that's exactly my hope. Less of this > Or perhaps we should change my suggestion to be more like "prioritize > suggested sites over history items that have only been visited once", so > that those history items will end up appearing in thumbnails below our > nice-looking suggested sites. I bet this is probably how this originally > worked, when those default thumbnails were bookmarks, but implementing > suggested sites changed that. More of this

Review commit: https://reviewboard.mozilla.org/r/33175/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33175/

Comment on attachment 8714591 [details] MozReview Request: Bug 1213085 - Prioritize suggested sites over minimally (once?) visited sites in top sites. r=mcomella https://reviewboard.mozilla.org/r/33175/#review29917 Technically correct so r+. However, I don't think this is what we wanted to do in this bug – see comment 4. Also, this will probably conflict with ahunt's Cursor work where he is merging the suggested sites cursor with the top sites cursor – see bug 760956. Maybe Andrew can just spin this work into that if it's not too complicated? ::: mobile/android/base/java/org/mozilla/gecko/db/LocalBrowserDB.java:645 (Diff revision 1) > - String selection = DBUtils.concatenateWhere(Combined.HISTORY_ID + " <> -1", > + String selection = DBUtils.concatenateWhere(Combined.HISTORY_ID + " <> -1 AND " + > + History.VISITS + " > 1", It's a little weird that `DBUtils.concatenateWhere` abstracts away `a AND b` and then we explicitly add `AND` into the Strings it concatenates, but I'm not sure if there's a better way to fix this (beyond removing the wrapping function, but it must be there for a reason...)

Ah yeah, that's true - tablets have more top sites tiles than suggested sites will fill on first run, so we should still take into account 1-visit history items.

I agree with Mike that I don't think we should omit these sites from the query - rather we should prioritize the suggested sites over them. So I think this will involve looking into the suggested sites logic, not just the regular top sites logic.

Andrzej, needinfo-ing you on this since we talked a bit about this in person and how it doesn't make sense for this bug to be done before the top sites cursor rewrite.

Not working on this at the moment. Grisha, is this related to what you've been working on, and would you want to pick it up?

I think there are other bugs that are more important than this one, like bug 1237038 or bug 1254660.

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.