Closed Bug 1213121 Opened 9 years ago Closed 9 years ago

Intermittent w-e10s close-multiple.html | WebSockets: close() several times - assert_equals: expected 1 but got 0

Categories

(Core :: Networking: WebSockets, defect)

Product:
Core
Component:
Networking: WebSockets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
e10s + ---
firefox45 --- fixed

People

(Reporter: KWierso, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bug1213121.diff
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Blocks: e10s-tests
tracking-e10s: --- → +
This test calls close() and asserts that the onclose event listener will fire within 50ms of that.  It's not at all surprising that sometimes it doesn't.  This is the usual problem of a test trying to assert that something _doesn't_ happen....

We could try increasing the timeout, or making the test pass even if it loses the race by asserting i <= 1, not i == 1.
Flags: needinfo?(james)
Attached patch bug1213121.diff (deleted) — — Splinter Review 
Flags: needinfo?(james)

        Attachment #8687908 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 8687908 [details] [diff] [review]
bug1213121.diff

r=me

        Attachment #8687908 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
A `return;` is missing. rs+ to add it.

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8bc6ddb34ac7
https://hg.mozilla.org/mozilla-central/rev/c71907f31ba8
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

    
    

    
      
  

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: