There are two identical enableTestPlugin.js files in the tree: * dom/html/test/enableTestPlugin.js * layout/base/tests/enableTestPlugin.js When a content process load any file uses this script, it would crash, because the script sets enabledState of the plugin, but that is only allowed in the parent process. We may rewrite that script to make it ask the parent process to change the enabledState. FWIW, there are currently 8 tests use this script.

It seems asking parent process to change the enableState of plugin has been fixed in plugin tests long ago in bug 641685. That just didn't cover the plugin-related tests elsewhere. I think there are three strategies to fix this bug: 1. copy the code in dom/plugins/test/mochitest/utils.js to the enableTestPlugin.js files 2. move dom/plugins/test/mochitest/utils.js to be global accessible (e.g. SimpleTest/PluginUtils.js) 3. move tests use enableTestPlugin.js into dom/plugins/test/mochitest/ Not quite sure which is the best. For fullscreen plugin subtest, it is probably harder to move because of the dependency to fullscreen utils script. But others look fine. The simplest way, though, is copying code, but I guess it would increase long-term maintainance burden.

Let's do it the forth way :)

Bug 1213710 part 1 - Convert all html/xul files in dom/plugins/test/mochitest to unix format.

Bug 1213710 part 2 - Rename dom/plugins/test/mochitest/utils.js to plugin-utils.js. So that files outside this dir can also reference it without conflict.

Bug 1213710 part 3 - Remove enableTestPlugin.js files and make the tests reference plugin-utils.js directly.

The review has been placed there for 2 weeks. bsmedberg, any reason not reviewing these patches?

Comment on attachment 8677266 [details] MozReview Request: Bug 1213710 part 3 - Remove enableTestPlugin.js files and make the tests reference plugin-utils.js directly. https://reviewboard.mozilla.org/r/22915/#review21703 Sorry for the delay. I got stuck on not being able to r+ each commit separately, but that was stupid of me.

https://reviewboard.mozilla.org/r/22909/#review21705 Or maybe this is the right place to review it? Now I'm even more confused. There's no "ship it" button here.

Oh. I can submit it again via the traditional way, if you prefer. I haven't do any reviewing on reviewboard, so I have no idea how that works.

(In reply to Benjamin Smedberg [:bsmedberg] from comment #9) > https://reviewboard.mozilla.org/r/22909/#review21705 > > Or maybe this is the right place to review it? Now I'm even more confused. > There's no "ship it" button here. Carrying the r+ over to the other 2 patches. r=bsmedberg

https://hg.mozilla.org/integration/mozilla-inbound/rev/91c332b973c7f709e8c49dfaa400a5774660eb0c Bug 1213710 part 1 - Convert all html/xul files in dom/plugins/test/mochitest to unix format. r=bsmedberg https://hg.mozilla.org/integration/mozilla-inbound/rev/744faf917eebb624f26febc118451ed3467d2e84 Bug 1213710 part 2 - Rename dom/plugins/test/mochitest/utils.js to plugin-utils.js. r=bsmedberg https://hg.mozilla.org/integration/mozilla-inbound/rev/c3623da0112ef4e384c42d01d7eaa7934a56113c Bug 1213710 part 3 - Remove enableTestPlugin.js files and make the tests reference plugin-utils.js directly. r=bsmedberg

https://hg.mozilla.org/mozilla-central/rev/91c332b973c7 https://hg.mozilla.org/mozilla-central/rev/744faf917eeb https://hg.mozilla.org/mozilla-central/rev/c3623da0112e