Closed
Bug 1213847
Opened 9 years ago
Closed 9 years ago
Deprecate passing the auth object to the python client's individual methods
Categories
(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P3)
Tree Management Graveyard
Treeherder: Client Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Currently the auth object can either be passed when instantiating the client, or when calling the individual methods (eg `post_collection()`).
The latter was the original pattern, and made sense with the original oauth mechanism, since the client would have to pass different credentials for different repositories ("projects"), so wouldn't be able to re-use the same credentials for the whole session.
However now that we have per-user credentials, the same credentials work for all repositories, so we should deprecate it.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8672634 -
Flags: review?(mdoglio)
Updated•9 years ago
|
Attachment #8672634 -
Flags: review?(mdoglio) → review+
Comment 2•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/83730509b9728ae2c4111e1afc5eadfc8a51891f
Bug 1213847 - Remove superfluous newlines in the client/client tests
https://github.com/mozilla/treeherder/commit/5bd8132ee2c9f4ed760d985173098080201b9fff
Bug 1213847 - Deprecate passing the auth object to the client's methods
Since with the new per-user Hawk credentials, the same auth object can
be used for the whole session, so should just be passed when
instantiating TreeherderClient.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•