Closed Bug 1213885 Opened 9 years ago Closed 9 years ago

Editing a pinned site opens a window called "Edit bookmark"

Categories

(Firefox OS Graveyard :: Gaia::Bookmark, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Bookmark
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+

People

(Reporter: benfrancis, Assigned: gmarty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] gmarty:Bug-1213885-Editing-pinned-site-opens-window-called-Edit-bookmark > mozilla-b2g:master
(deleted), text/x-github-pull-request
apastor
: review+
Details
What should the heading say with the new UI design? [Blocking Requested - why for this release]: Inconsistent terminology may be confusing.
Flags: needinfo?(fdjabri)
Whiteboard: [systemsfe]
blocking-b2g: 2.5? → 2.5+
QA Whiteboard: [COM=Pin the Web]
Priority: -- → P3
Liz, Eric, what do you think this string should be? "Edit Pinned Website"?
Flags: needinfo?(epang)
Flags: needinfo?(ehunt)
Ben: that makes sense to me.
Flags: needinfo?(ehunt)
looks like Liz has already responded :). Thanks Liz!
Flags: needinfo?(fdjabri)
Flags: needinfo?(epang)
Assignee: nobody → gmarty
Comment on attachment 8674841 [details] [gaia] gmarty:Bug-1213885-Editing-pinned-site-opens-window-called-Edit-bookmark > mozilla-b2g:master I also renamed the `Updated bookmark` string. I could have renamed the app in the manifest, but it's not a user facing string and we may still revert to `bookmark` in the next releases.
Attachment #8674841 - Flags: review?(apastor)
Comment on attachment 8674841 [details] [gaia] gmarty:Bug-1213885-Editing-pinned-site-opens-window-called-Edit-bookmark > mozilla-b2g:master Looks good, but let's take advantatge of this bug for removing mozL10n.get and replace it with formatValue. https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices
Attachment #8674841 - Flags: review?(apastor) → review+
Landed in https://github.com/mozilla-b2g/gaia/commit/fd3a6621b6de0fac1605b28d3cf12c13c013d366
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified on [Flame] Build ID 20151019150205 Gaia Revision a87f947366c2e044bd6336e1982419ac45378969 Gaia Date 2015-10-19 15:22:08 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c Gecko Version 44.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151019.182947 Firmware Date Mon Oct 19 18:29:58 EDT 2015 Bootloader L1TC000118D0 [Aries] Build ID 20151019205841 Gaia Revision a87f947366c2e044bd6336e1982419ac45378969 Gaia Date 2015-10-19 15:22:08 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c Gecko Version 44.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151019.201730 Firmware Date Mon Oct 19 20:17:38 UTC 2015 Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: