Closed
Bug 1213906
Opened 9 years ago
Closed 9 years ago
Change e-mail text invitation to fit the new user journey
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
Iteration:
45.2 - Nov 30
People
(Reporter: RT, Assigned: crafuse)
References
Details
(Whiteboard: [web sharing][strings] )
User Story
* E-mail copy when there is context: [SUBJECT] Your invitation to browse the Web together [BODY] A friend is waiting for you on Firefox Hello. Click the link to connect and browse [URL domain name] together: [auto generated Hello link here] ____________ Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at firefox.com/hello * E-mail copy when there is no context: [SUBJECT] Your invitation to browse the Web together [BODY] A friend is waiting for you on Firefox Hello. Click the link to connect and browse the Web together: [auto generated Hello link here] ____________ Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at firefox.com/hello Tech Checklist * Update loop.properties email strings, incrementing each string identifier number
Attachments
(2 files, 3 obsolete files)
(deleted),
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Updated•9 years ago
|
Reporter | ||
Comment 1•9 years ago
|
||
Matej and Fabio, could you please suggest updated strings based on the 44 value proposition (there is always context, this is about sharing a website in real time). Thanks!
User Story: (updated)
Flags: needinfo?(matej)
Flags: needinfo?(frios)
Comment 2•9 years ago
|
||
(In reply to Romain Testard [:RT] from comment #1)
> Matej and Fabio, could you please suggest updated strings based on the 44
> value proposition (there is always context, this is about sharing a website
> in real time). Thanks!
Based on some other bugs and email conversations, it sounds like we're still trying to figure out how best to communicate this feature. I think we should wait until we have that sorted before tackling this.
Flags: needinfo?(matej)
Comment 3•9 years ago
|
||
Per comments in Bug 1211351 we should use the word "Browse", initially. I'd like to suggest copy:
****EMAIL****
[SUBJECT]
Your invitation to browse the web together
[BODY]
A friend is waiting for you on Firefox Hello. Click the link to connect with them now: [auto generated Hello link here]
____________
Firefox Hello let's you browse the web together. Use it when you want to get things done with others. Plan together. Laugh together. Work together. Learn more at firefox.com/hello
****FACEBOOK****
- Large Firefox Hello graphic
- Message Entered by the user. Facebook won't let us force this
- The title: "Your invitation to browse the web together"
- The shared URL: <Conversation URL>
- The description: "Plan together. Laugh together. Work together."
Flags: needinfo?(rtestard)
Flags: needinfo?(matej)
Flags: needinfo?(frios)
Reporter | ||
Comment 4•9 years ago
|
||
Thanks Fabio
How about we add details about what the user is about to be browsing since we'll have that data?
[SUBJECT]
A friend want to browse booking.com with you now
[BODY]
A friend is waiting for you on Firefox Hello. Click the link to connect and browse booking.com with him now: [auto generated Hello link here]
____________
Firefox Hello let's you browse the web together. Use it when you want to get things done with others. Plan together. Laugh together. Work together. Learn more at firefox.com/hello
****FACEBOOK****
- Large Firefox Hello graphic
- Message Entered by the user. Facebook won't let us force this
- The title: "YA friend want to browse booking.com with you now "
- The shared URL: <Conversation URL>
- The description: "Plan together. Laugh together. Work together."
Flags: needinfo?(rtestard)
Comment 5•9 years ago
|
||
I like Romain's suggestion in comment 4, but I made a few edits:
[SUBJECT]
A friend has invited you to browse booking.com
[BODY]
A friend is waiting for you on Firefox Hello. Click the link to connect and browse booking.com together: [auto generated Hello link here]
____________
Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at firefox.com/hello
****FACEBOOK****
- Large Firefox Hello graphic
- Message Entered by the user. Facebook won't let us force this
- The title: "A friend would like to browse booking.com with you"
- The shared URL: <Conversation URL>
- The description: "Plan together. Work together. Laugh together."
Flags: needinfo?(matej)
Comment 6•9 years ago
|
||
(In reply to Matej Novak [:matej] from comment #5)
> I like Romain's suggestion in comment 4, but I made a few edits:
>
> [SUBJECT]
> A friend has invited you to browse booking.com
Can't have it dynamically pulled for the subject line. We run a big risk of getting sent to spam so not worth it.
> [BODY]
> A friend is waiting for you on Firefox Hello. Click the link to connect and
> browse booking.com together: [auto generated Hello link here]
In terms of having it included in the body. Are we confident that the meta tags or URL will play nice? If so, then sounds good. For the link clicker, the #1 object is connection, so don't want to risk the email looking funky and preventing connection.
> ____________
>
> Firefox Hello lets you browse the Web with your friends. Use it when you
> want to get things done: plan together, work together, laugh together. Learn
> more at firefox.com/hello
>
>
>
> ****FACEBOOK****
>
> - Large Firefox Hello graphic
> - Message Entered by the user. Facebook won't let us force this
> - The title: "A friend would like to browse booking.com with you"
I doubt we can do dynamic here, but cool if we can!
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Fabio Rios [:frios] from comment #6)
> (In reply to Matej Novak [:matej] from comment #5)
> > I like Romain's suggestion in comment 4, but I made a few edits:
> >
> > [SUBJECT]
> > A friend has invited you to browse booking.com
>
> Can't have it dynamically pulled for the subject line. We run a big risk of
> getting sent to spam so not worth it.
>
OK, let's then keep "Your invitation to browse the web together" as you suggested
> > [BODY]
> > A friend is waiting for you on Firefox Hello. Click the link to connect and
> > browse booking.com together: [auto generated Hello link here]
>
> In terms of having it included in the body. Are we confident that the meta
> tags or URL will play nice? If so, then sounds good. For the link clicker,
> the #1 object is connection, so don't want to risk the email looking funky
> and preventing connection.
The booking.com URL won't be clickable since the full URL won't be used (better to focus clicks to the Hello URL - a single call to action).
I'm not sure I understand the question about the meta tags?
>
> > ____________
> >
> > Firefox Hello lets you browse the Web with your friends. Use it when you
> > want to get things done: plan together, work together, laugh together. Learn
> > more at firefox.com/hello
> >
> >
> >
> > ****FACEBOOK****
> >
> > - Large Firefox Hello graphic
> > - Message Entered by the user. Facebook won't let us force this
> > - The title: "A friend would like to browse booking.com with you"
> I doubt we can do dynamic here, but cool if we can!
OK let's see this with engineering.
As a fall-back are we good with "A friend would like to browse a website with you" ?
Comment 8•9 years ago
|
||
(In reply to Romain Testard [:RT] from comment #7)
> (In reply to Fabio Rios [:frios] from comment #6)
> > (In reply to Matej Novak [:matej] from comment #5)
> > > I like Romain's suggestion in comment 4, but I made a few edits:
> > >
> > > [SUBJECT]
> > > A friend has invited you to browse booking.com
> >
> > Can't have it dynamically pulled for the subject line. We run a big risk of
> > getting sent to spam so not worth it.
> >
>
> OK, let's then keep "Your invitation to browse the web together" as you
> suggested
Let's just make sure "Web" is capitalized. Thanks.
Reporter | ||
Comment 10•9 years ago
|
||
Just as an update, this is now final since agreed with Marketing.
We can move to implementation for this.
Reporter | ||
Updated•9 years ago
|
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
Assignee: nobody → chris
Assignee | ||
Updated•9 years ago
|
Assignee: chris → chris.rafuse
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
Whiteboard: [web sharing] → [web sharing][strings]
Assignee | ||
Comment 11•9 years ago
|
||
A friend is waiting for you on Firefox Hello. Click the link to connect and browse mini-itx.com - news together: http://localhost:3000/content/2yd4WQjJ9cg#T4daOB0B3DTfqJzGyt7NEw
____________
Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at http://www.firefox.com/hello
---END
1) Above email copy is final output. Do you want http://www. in front of firefox.com/hello as it will auto-format to link in email?
2) How should shared email body be without context? Two email body types share_email_body6 and share_email_body_context (set to the context url info).
Flags: needinfo?(rtestard)
Keywords: leave-open
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8680904 [details] [diff] [review]
Change e-mail content
Passed in the context url into the EmailRoomUrl and into composeCallUrlEmail.
Updated and incremented strings for: share_email_subject7, share_email_body_context3 and share_email_footer2
Non-context email message has not changed.
Output example:
Subject: Your invitation to browse the Web together
A friend is waiting for you on Firefox Hello. Click the link to connect and browse www.mini-itx.com together: http://localhost:3000/content/cfI39Q55oa4#QqQwHR_ehY5JfltW7tkzSQ
____________
Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at http://www.firefox.com/hello
Attachment #8680904 -
Flags: ui-review?(rtestard)
Attachment #8680904 -
Flags: review?(dmose)
Assignee | ||
Updated•9 years ago
|
Attachment #8680904 -
Attachment is obsolete: true
Attachment #8680904 -
Flags: ui-review?(rtestard)
Attachment #8680904 -
Flags: review?(dmose)
Assignee | ||
Comment 14•9 years ago
|
||
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8680997 [details] [diff] [review]
Change e-mail content
Adjusted tests for new functionality.
Attachment #8680997 -
Flags: ui-review?(rtestard)
Attachment #8680997 -
Flags: review?(dmose)
Reporter | ||
Comment 16•9 years ago
|
||
(In reply to Chris Rafuse from comment #11)
> A friend is waiting for you on Firefox Hello. Click the link to connect and
> browse mini-itx.com - news together:
> http://localhost:3000/content/2yd4WQjJ9cg#T4daOB0B3DTfqJzGyt7NEw
>
> ____________
> Firefox Hello lets you browse the Web with your friends. Use it when you
> want to get things done: plan together, work together, laugh together. Learn
> more at http://www.firefox.com/hello
>
> ---END
>
> 1) Above email copy is final output. Do you want http://www. in front of
> firefox.com/hello as it will auto-format to link in email?
Yes please!
>
> 2) How should shared email body be without context? Two email body types
> share_email_body6 and share_email_body_context (set to the context url info).
If I get this right, this is only for previously created Hello URLs (prior to new user journey since the new user journey will force a context always).
Let's use the following:
[BODY]
A friend is waiting for you on Firefox Hello. Click the link to connect and browse a website together: [auto generated Hello link here]
____________
Firefox Hello lets you browse the Web with your friends. Use it when you want to get things done: plan together, work together, laugh together. Learn more at firefox.com/hello
Flags: needinfo?(rtestard)
Comment 17•9 years ago
|
||
Comment on attachment 8680997 [details] [diff] [review]
Change e-mail content
Review of attachment 8680997 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch! This is on the right track, some requested changes are inlined here...
::: browser/components/loop/content/js/roomViews.jsx
@@ +271,2 @@
> var contextURL = roomData.roomContextUrls && roomData.roomContextUrls[0];
> + console.log("contextURL", contextURL);
Please drop the console.log statements.
@@ +275,5 @@
> + contextURL = new URL(contextURL.location).hostname;
> + console.log("contextURL", contextURL);
> + } catch (ex) {
> + contextURL = undefined;
> + }
Please push this into a separate function in utils so that it can be handled and unit-tested in one place?
::: browser/components/loop/content/shared/js/utils.js
@@ +395,2 @@
>
> + if (contextDescription !== "undefined") {
This change wants a unit test.
::: browser/components/loop/test/desktop-local/roomViews_test.js
@@ +218,5 @@
> roomData: { roomUrl: "http://invalid" }
> });
>
> var emailBtn = view.getDOMNode().querySelector(".btn-email");
> + console.log("emailBtn", emailBtn);
This probably wants to go. :-)
@@ +237,5 @@
> var description = "Hello, is it me you're looking for?";
> view = mountTestComponent({
> roomData: {
> roomUrl: url,
> + roomContextUrls: [{ description: description, location: "www.mozilla.com" }]
I'm guessing we want to check (either here or in another test) that location is being processed correctly?
::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +59,5 @@
> ## the appropriate action.
> retry_button=Retry
>
> +share_email_subject7=Your invitation to browse the Web together
> +## remove following i f not found in project
The above comment wants to go, I'm thinking. :-)
Attachment #8680997 -
Flags: review?(dmose) → feedback+
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8680997 -
Attachment is obsolete: true
Attachment #8680997 -
Flags: ui-review?(rtestard)
Assignee | ||
Updated•9 years ago
|
Attachment #8681432 -
Attachment is obsolete: true
Assignee | ||
Comment 20•9 years ago
|
||
Comment on attachment 8681433 [details] [diff] [review]
Change e-mail content
New copy for non-context or have no location(new tab, start page).
Replaced hostname parse code with util.js formatURL function to extract the hostname. Should have tests attached.
Adjusted tests to succeed.
Removed console.logs.
Final copy of the non-context email:
A friend is waiting for you on Firefox Hello. Click the link to connect and browse a website together: http://localhost:3000/content/y5mCRu-B96I#BLZ3unEiL1FGBVNDjHRLzQ
END-------------------
Question: do we want the domain name on the roomlist entry email link email?
Attachment #8681433 -
Flags: ui-review?(rtestard)
Attachment #8681433 -
Flags: review?(dmose)
Comment 21•9 years ago
|
||
RT: this is also for cases in the new user journey where there is an untitled web page, or we have some sort of problem decrypting the context. I'd actually suggest "A friend is waiting for you on Firefox Hello. Click the link to connect and browse the web together: http://localhost:3000/content/y5mCRu-B96I#BLZ3unEiL1FGBVNDjHRLzQ".
The main change I'm proposing is that we talk about "browsing the web", since tab sharing is actually more powerful than just a single site at a time.
Comment 22•9 years ago
|
||
(In reply to Dan Mosedale (:dmose) - use needinfo flag for response from comment #21)
> RT: this is also for cases in the new user journey where there is an
> untitled web page, or we have some sort of problem decrypting the context.
Agree. This was my comment #6 about making sure the page URL or meta tags "play nice". Is it safe to say nearly 100% will be OK?
If so, probably fine as is with specific content or page that is up for discussion. The context should help drive the clicks since it's likely both individuals know there's something to be discussed before they resort to Hello.
Reporter | ||
Comment 23•9 years ago
|
||
Makes sense, user story updated with Dan's suggestion.
User Story: (updated)
Comment 24•9 years ago
|
||
(In reply to Fabio Rios [:frios] from comment #22)
> (In reply to Dan Mosedale (:dmose) - use needinfo flag for response from
> comment #21)
> > RT: this is also for cases in the new user journey where there is an
> > untitled web page, or we have some sort of problem decrypting the context.
>
> Agree. This was my comment #6 about making sure the page URL or meta tags
> "play nice". Is it safe to say nearly 100% will be OK?
Yeah, for some definition of nearly between 95% and 99%, which we're unlikely to know until we deploy.
Comment 25•9 years ago
|
||
Comment on attachment 8681433 [details] [diff] [review]
Change e-mail content
Review of attachment 8681433 [details] [diff] [review]:
-----------------------------------------------------------------
Pair reviewed with Chris. We cleaned up some edge cases and fixed a test, r+ on the resulting patch.
Attachment #8681433 -
Flags: review?(dmose) → review+
Comment 26•9 years ago
|
||
Updated to fix minor review comments and use latest suggested text.
Comment 27•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/901a0736dd16ba366d2de0ec08cab975429fa4b2
Bug 1213906-Change email invitation to fit new user journey, r=dmose
Comment 28•9 years ago
|
||
Comment on attachment 8681433 [details] [diff] [review]
Change e-mail content
Since the updated text came from the latest user story, I think it's safe to go ahead and land, which I've done. Leaving the ui-review, in case RT wants to go over it again.
Comment 29•9 years ago
|
||
bugherder |
Comment 30•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Assignee | ||
Updated•9 years ago
|
status-b2g-v2.5:
fixed → ---
Summary: Change e-mail and Facebook text invitations to fit the new user journey → Change e-mail text invitation to fit the new user journey
Assignee | ||
Updated•9 years ago
|
User Story: (updated)
Assignee | ||
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
Iteration: --- → 45.2 - Nov 30
Assignee | ||
Comment 31•9 years ago
|
||
Removed Facebook invitation scope requirement and marking as resolved:
REMOVED
* Facebook copy:
- A 1200 x 630 pixels image promoting Firefox Hello (the visual is provided in https://bug1177949.bmoattachments.org/attachment.cgi?id=8635811)
- Message: Entered by the user, Facebook won't let us force this
- The title: "A friend would like to browse [URL domain name] with you"
- The shared URL: <Conversation URL>
- The description: "Plan together. Laugh together. Work together."
Note: We are unsure whether we're able to put dynamic content in the Facebook invite title, please use "A friend would like to browse the Web with you" if it's not possible.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 32•9 years ago
|
||
Comment on attachment 8681433 [details] [diff] [review]
Change e-mail content
Removing what seems to be an obsolete request (resolved in comment 21).
Attachment #8681433 -
Flags: ui-review?(rtestard)
Comment 33•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•