Closed
Bug 1214163
Opened 9 years ago
Closed 9 years ago
Cleanup SetPropertyIC::update
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
SetPropertyIC::update is a bit of a mess and hard to read. This patch moves the code to attach stubs to a new method, tryAttachStub, and adds separate methods for each type (tryAttachProxy, tryAttachNative, etc), like GetPropertyIC does. No change in behavior.
Attachment #8673040 -
Flags: review?(efaustbmo)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8673040 [details] [diff] [review] Patch Review of attachment 8673040 [details] [diff] [review]: ----------------------------------------------------------------- Man, this way is prettier. I remember when I did this for GetPropertyIC. Feels so good.
Attachment #8673040 -
Flags: review?(efaustbmo) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03f521f50792
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•