STR: 1. Create a new profile, and run Firefox using it, and open a non-e10s window. 2. Go to <https://marcoscaceres.github.io/sw-workshop/finished/>. Disable your network connection. Reload. Everything works. 3. Open devtools, go to Settings, and check "Disable cache (when toolbox is open)". 4. Reload (still with the network connection disabled.) The interception doesn't work.

Comment on attachment 8673372 [details] [diff] [review] Avoid bypassing opening a cache entry for possibly intercepted channels Review of attachment 8673372 [details] [diff] [review]: ----------------------------------------------------------------- Michael, do you mind taking a look at this too? I was thinking about this patch yesterday, specifically about what it could possibly break that I need to test, and I can't really say for sure, so I'd appreciate a second opinion as well. :-) Thanks!

Ping?

I guess I'll land this, and address any comments post landing. It's better to land sooner to see if it breaks something.

Comment on attachment 8673372 [details] [diff] [review] Avoid bypassing opening a cache entry for possibly intercepted channels Sorry for the delay. Looks good to me, but I'd like Honza to have a look at it too, because he knows this code best.

Comment on attachment 8673372 [details] [diff] [review] Avoid bypassing opening a cache entry for possibly intercepted channels Review of attachment 8673372 [details] [diff] [review]: ----------------------------------------------------------------- Josh should check on this. However, we want to move away from using the cache for the intercept feature soon. It shows to have drawbacks... like this one.

Yeah, I agree! It would be nice if we can talk about what to do in Orlando.

Comment on attachment 8673372 [details] [diff] [review] Avoid bypassing opening a cache entry for possibly intercepted channels Review of attachment 8673372 [details] [diff] [review]: ----------------------------------------------------------------- Agreed. The more edge cases like these that we uncover, the stronger my desire to rewrite it all becomes.