Closed Bug 1214799 Opened 9 years ago Closed 9 years ago

Localize memory tool

Categories

(DevTools :: Memory, defect)

43 Branch
defect
Not set
normal

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

Before we launch we should change all hardcoded strings to be localized.
Strings we need: * Take snapshot button on load States, for list items as well as in the big panel (may be different? strings in list item need to be relatively short: * Saving a snapshot * Reading a snapshot -- I think "Reading snapshot into memory" is a bit confusing, since it is the memory tool. * Taking census -- What's a good, public-facing name for Censuses and Breakdowns?
Attached patch 1214799-memory-l10n.patch (deleted) — Splinter Review
Attachment #8680483 - Flags: review?(nfitzgerald)
Comment on attachment 8680483 [details] [diff] [review] 1214799-memory-l10n.patch Review of attachment 8680483 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/memory/constants.js @@ +6,5 @@ > > +const { Cu } = require("chrome"); > +Cu.import("resource://devtools/client/shared/widgets/ViewHelpers.jsm"); > +const STRINGS_URI = "chrome://browser/locale/devtools/memory.properties" > +const L10N = exports.L10N = new ViewHelpers.L10N(STRINGS_URI); Think this belongs in utils, not constants.
Attachment #8680483 - Flags: review?(nfitzgerald) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: