Botond Ballo [:botond] Reporter
	Description • 9 years ago

STR:
  1. Load http://telewizjarepublika.pl/szumlewicz-korwin-chce-dogadac-sie-z-pis-tylko-zjednoczona-lewica-jest-antysystemowa,24842.html
  2. Scroll down until you see the Flash video just above the comments
  3. Make sure you're running recent Nightly with APZ enabled, or
     enable APZ manually (layers.async-pan-zoom.enabled=true).
  3. Scroll up and down and observe the video.

The video's position lags behind as you scroll. I would have expected bug 1137944 to fix this by hiding the plugin during an async scroll.

	Botond Ballo [:botond] Reporter
	Comment 1 • 9 years ago

Jim, would you expect the fix in bug 1137944 to apply to this case, or is there something special about this page?

	Jim Mathies [:jimm] Assignee
	Comment 2 • 9 years ago

Hmm, yeah this should get hidden. Something must be going wrong with our scroll tracking in the content process in nsGfxScrollFrame I guess. I'll take a look.

	Jim Mathies [:jimm] Assignee
	Comment 3 • 9 years ago

Ah this plugin is embedded in an iframe, bet that has something to do with it.

	Jim Mathies [:jimm] Assignee
	Comment 4 • 9 years ago

Need to walk sub documents as well.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 5 • 9 years ago

Comment on attachment 8674425 [details] [diff] [review]
patch

Review of attachment 8674425 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. needs a test :-)

	Jim Mathies [:jimm] Assignee
	Comment 6 • 9 years ago

good idea. carbon copies of the original scroll tests with a sub frame plugin.

	Pulsebot
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/59588063362c
https://hg.mozilla.org/integration/mozilla-inbound/rev/eddce960bab6

	Jim Mathies [:jimm] Assignee
	Comment 8 • 9 years ago

Is is possible that we might have an iframe within an iframe that has a plugin? If so, I think I need to add yet another layer to this where I walk subframes, and then try to walk subframes within each sub frame, and so on down the tree.

	Jim Mathies [:jimm] Assignee
	Comment 9 • 9 years ago

Hmm, we don't do this in nsPresShell, so maybe EnumerateSubDocuments picks up all sub documents. I can't tell from the nsIDocument header. I'll test once this work gets out to mc.

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/59588063362c
https://hg.mozilla.org/mozilla-central/rev/eddce960bab6

	Carsten Book [:Tomcat]
	Comment 11 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/59588063362c
https://hg.mozilla.org/mozilla-central/rev/eddce960bab6

	2ljpswpih
	Comment 12 • 9 years ago

@ Carsten, should it look like this? I've sent you an e-mail with video of this bug.

	Carsten Book [:Tomcat]
	Comment 13 • 9 years ago

(In reply to to_du from comment #12)
> @ Carsten, should it look like this? I've sent you an e-mail with video of
> this bug.

Hi, i'm not the initial developer who wrote the fix so i can't say (i only checked in the patch to the central repo). Jim is the developer who worked on this fix, redirecting the needinfo to him

	2ljpswpih
	Comment 14 • 9 years ago

Can you send this video to Jim?

	Carsten Book [:Tomcat]
	Comment 15 • 9 years ago

maybe it would be more useful to attach it here ?

	Jim Mathies [:jimm] Assignee
	Comment 16 • 9 years ago

I'm not sure what's being discussed, is this bug 1212813? If so attach it there. New regressions related to the work here (hiding plugins in subframes while scrolling) should be filed individually.

	2ljpswpih
	Comment 17 • 9 years ago

https://youtu.be/dWhFiQOufnw

	Botond Ballo [:botond] Reporter
	Comment 18 • 9 years ago

(In reply to to_du from comment #17)
> https://youtu.be/dWhFiQOufnw

This is not just bug 1212813; the video is only partially redrawn when scrolling stops. Please file a new bug for this.

	2ljpswpih
	Comment 19 • 9 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1217168