Closed Bug 1214939 Opened 9 years ago Closed 9 years ago

Black Material check in Android 4* password dialog

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed, b2g-v2.5 fixed, fennec44+)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed
fennec 44+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files)

Screenshot of the issue
(deleted), image/png
Details
MozReview Request: Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian
(deleted), text/x-review-board-request
sebastian
: review+
Details
Attached image Screenshot of the issue (deleted) —
It's strange because Gecko*DialogBase inherits from Holo styles – I'm guessing this doesn't inherit from that.
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #0) > It's strange because Gecko*DialogBase inherits from Holo styles – I'm > guessing this doesn't inherit from that. But the EditText actually has Holo styles. :)
44+ for now to follow Theme.AppCompat but I feel this is lower priority than the other regressions and bugs I'm working on.
tracking-fennec: --- → 44+
We found out these are not being inflated correctly in bug 1220196 so we explicitly used the AppCompatCheckBox. It appears this one is inflated in code, so we should also explicitly use the AppCompatCheckBox. However, unlike the other bug, this is not likely to be a work around because I don't think AppCompat dynamically injects `AppCompatCheckBox`es in code, like it does in xml.
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1220196
Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian This way it inherits from the AppCompat styles like accentColor.
Attachment #8681539 - Flags: review?(s.kaspari)
Comment on attachment 8681539 [details] MozReview Request: Bug 1214939 - Explicitly use AppCompatCheckBox in PromptInput. r=sebastian https://reviewboard.mozilla.org/r/23853/#review21345 Nice and simple. :)
Attachment #8681539 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/af1868f1fc78
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: