Closed
Bug 1215196
Opened 9 years ago
Closed 9 years ago
A bunch of serviceworker test resource files act like separate tests
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
There are six HTML files in testing/web-platform/mozilla/tests/service-workers/service-worker/resources that include testharness.js. That makes them testharness tests for purposes of the harness, so it tries to run them. And they're not tests, so they time out.
Now 5 of these have .ini files saying they time out. The 6th one was added in bug 1210581 and isn't added to the manifest yet, but the next time there's a test import it will be, I bet, and pick up its own .ini file.
Worse yet, it's a land mine for anyone using mach web-platform-tests-create, since that will add it to the manifest.
The relevant files:
resources/fetch-request-resources-iframe.https.html
resources/fetch-request-xhr-iframe.https.html
resources/fetch-response-xhr-iframe.https.html
resources/invalid-blobtype-iframe.https.html
resources/invalid-header-iframe.https.html
resources/worker-interception-iframe.https.html
Assignee | ||
Comment 1•9 years ago
|
||
Hmm, which manifest are you talking about? I thought that these tests are run by some kind of directory traversal, not by declaring them in manifests?
Comment 2•9 years ago
|
||
This manifest:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/MANIFEST.json
And for example, these are not tests:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/mozilla/meta/service-workers/service-worker/resources
The wpt tests assume anything importing testharness.js are a test.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Reporter | ||
Comment 3•9 years ago
|
||
> I thought that these tests are run by some kind of directory traversal, not by declaring
> them in manifests?
There is a script that does a directory traversal and builds a manifest. It's normally run when we take a new test import from upstream or when new tests are added. The tests are run based on the manifest.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8675073 -
Flags: review?(bkelly)
Updated•9 years ago
|
Attachment #8675073 -
Flags: review?(bkelly) → review+
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•