Closed
Bug 1215234
Opened 9 years ago
Closed 9 years ago
update MP4Metadata.rs to mp4parse v0.1.0
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(3 files)
(deleted),
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
Version bump so we can start hooking up the C++ side.
Assignee | ||
Comment 1•9 years ago
|
||
This turned out not to have important changes, but I'd rather build against what we're building against out-of-tree.
Attachment #8674398 -
Flags: review?(kinetik)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8674415 -
Flags: review?(kinetik)
Assignee | ||
Comment 3•9 years ago
|
||
gtest needs updating for the new read_box_from_buffer signature.
Attachment #8674416 -
Flags: review?(kinetik)
Updated•9 years ago
|
Attachment #8674398 -
Flags: review?(kinetik) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8674416 [details] [diff] [review]
Update gtest for mp4parse v0.1.0
Any idea why it fails?
Attachment #8674416 -
Flags: review?(kinetik) → review+
Updated•9 years ago
|
Attachment #8674415 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Matthew Gregan [:kinetik] from comment #4)
> Any idea why it fails?
I think it might be EOF error catch clobbering something? But not sure. The dump.cc example in the mp4parse-rust repo fails similarly. It only loaded the first 4k by default, but (a) that should be enough and (b) it still fails if I raise the chunk size to 40M.
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/19b7efeb7c6d
https://hg.mozilla.org/mozilla-central/rev/e6ad4eedc016
https://hg.mozilla.org/mozilla-central/rev/3f2f87f5f187
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•