Closed
Bug 1215365
Opened 9 years ago
Closed 9 years ago
Sync the ua style sheets of fullscreen element to the latest spec
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
There has been several update on the default style sheet of fullscreen elements in the Fullscreen API spec, we should update our ua.css accordingly.
Note that we currently have "background: black" in our style sheet while the spec does not have. This line can be removed only when we implement bug 1064843.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8701399 -
Flags: review?(cam)
Updated•9 years ago
|
Attachment #8701399 -
Flags: review?(cam) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e026b0e24a5a123ab590c9c30968e95fddf1db5
Bug 1215365 - Update ua style sheet of fullscreen element. r=heycam
I had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4cefc9388515 for gij(19) failures in browser_fullscreen_utility_tray_test.js
https://treeherder.mozilla.org/logviewer.html#?job_id=19052256&repo=mozilla-inbound
Flags: needinfo?(quanxunzhen)
It doesn't appear to be a permafail, but it did fail 8 out of 9 times so far.
Assignee | ||
Comment 5•9 years ago
|
||
I'm going to reland this patch without removing the z-index line. We would probably need more work to remove that line, especially on gaia side.
That line is useless for web content because all fullscreen elements from content other than :root are now rendered in the top layer, while it is not true for <iframe mozbrowser>.
Assignee | ||
Comment 6•9 years ago
|
||
The "background: black" line will be removed in bug 1064843 directly. So this bug no longer depends on that one.
No longer depends on: ::backdrop
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf2d8f46f02c44512c769689cdcf72aebd50e71e
Bug 1215365 - Update ua style sheet of fullscreen element. r=heycam
Assignee | ||
Comment 8•9 years ago
|
||
As m-i has merged my patch for bug 1235470, reland this patch.
Flags: needinfo?(quanxunzhen)
Comment 9•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•