Closed
Bug 1215629
Opened 9 years ago
Closed 9 years ago
Remove the nsDebug logger
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We already fprintf, __android_log_print, etc, we don't need to loop in the logging system as well.
Also note NS_DebugBreak can be called very early in startup and very late in shutdown so this will start to lead to possible issues of logging too early / too late as we improve the mozilla logging module.
Assignee | ||
Comment 1•9 years ago
|
||
Lets go ahead and do this before bug 1174785; it looks like it will make things
easier.
Attachment #8675803 -
Flags: review?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8675803 [details] [diff] [review]
Remove nsDebug logger
Review of attachment 8675803 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, but please post on dev-platform about the removal and wait a day or so before committing to see if anybody yells extremely loudly about it.
Attachment #8675803 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8675803 [details] [diff] [review]
> Remove nsDebug logger
>
> Review of attachment 8675803 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=me, but please post on dev-platform about the removal and wait a day or so
> before committing to see if anybody yells extremely loudly about it.
Try push including this built fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=472a09e30476
Posted to dev platform earlier today:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/mcsSEX4yJls
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc66762ac6ec54351a63f9d18cf4ef9f3d31a54
Bug 1215629 - Remove nsDebug logger. r=froydnj
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•