Closed
Bug 1215748
Opened 9 years ago
Closed 9 years ago
Consider llvm-dsymutil for mac builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: chmanchester, Assigned: ted)
References
Details
Attachments
(1 file)
I found running the buildsymbols step locally that running dsymutil on libxul takes significantly longer than dumping symbols for the rest of the binaries, so by the time we run dump_syms on libxul everything else is done and we're only utilizing one core.
Locally using llvm-dsymutil in place of /usr/bin/dsymutil cuts the whole thing down from 10 minutes to about 6 (this usually take 15-25 minutes in automation).
Reporter | ||
Comment 1•9 years ago
|
||
Similarly compelling time savings in https://treeherder.mozilla.org/#/jobs?repo=try&revision=ced4a01b3f1e (debug down from 15 to 7 minutes, opt from 25 to 11), but a flood of warnings like:
20:47:35 INFO - 2015-10-16 20:47:35: dwarf_cu_to_module.cc:584: INFO: dist/bin/XUL.dSYM/Contents/Resources/DWARF/XUL: the DIE at offset 0xd326de1 has a DW_AT_abstract_origin attribute referring to the die at offset 0xd326e19, which either was not marked as an inline, or comes later in the file
20:47:35 INFO - 2015-10-16 20:47:35: dwarf_cu_to_module.cc:633: INFO: dist/bin/XUL.dSYM/Contents/Resources/DWARF/XUL: warning: function at offset 0xd326de1 has no name
Reporter | ||
Comment 2•9 years ago
|
||
Actually those same warnings are on trunk. llvm-dsymutil is the default in xcode 7, so maybe it's ready.
Assignee | ||
Comment 3•9 years ago
|
||
Guess we should just do this. I'll try a quick sanity check on a local build to see if the dump_syms output is the same.
FYI, you shouldn't need to add anything to the tooltool manifest, llvm-dsymutil is already in the clang package we use (now that we're on a new enough clang version), so you can just use $topsrcdir/clang/bin/llvm-dsymutil.
Reporter | ||
Comment 4•9 years ago
|
||
Oh, that was updated Friday, nice!
I found some differences in the sym files when I looked at this briefly yesterday. I guess it's possible not all the relevant patches are upstream.
Assignee | ||
Comment 5•9 years ago
|
||
I just tried this with the version of clang that I had updated our official builds to (ehsan has since updated to a slightly-newer build):
$ ~/clang/bin/llvm-dsymutil -version
LLVM (http://llvm.org/):
LLVM version 3.8.0svn
The .dSYM bundles aren't bit-identical, but the output of dump_syms is identical, which is good enough for me!
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ted
Assignee | ||
Comment 7•9 years ago
|
||
bug 1215748 - use llvm-dsymutil for mac builds. r?mshal
Attachment #8676927 -
Flags: review?(mshal)
Comment 8•9 years ago
|
||
Comment on attachment 8676927 [details]
MozReview Request: bug 1215748 - use llvm-dsymutil for mac builds. r?mshal
https://reviewboard.mozilla.org/r/22835/#review20471
Attachment #8676927 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11d88c9683e58c28f417a9122c2101ea66edeba9
bug 1215748 - use llvm-dsymutil for mac builds. r=mshal
Comment 10•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•