User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20151014143721 Steps to reproduce: In Windows 10 enable the Hey Cortana search feature. Google will already be set to the default search engine for Firefox and will work when typing searches in the search bar of Windows 10. When using the Hey Cortana voice command the search is carried out in Bing regardless of the setting for search engine in Firefox being set to use this search engine for Windows Searches Actual results: Used Hey Cortana to carry out a web search via voice command and the search was conducted in Bing insted of Google within Firefox Expected results: The Hey Cortana voice search should have searched Google

According to bug 1177237 this ought to have been uplifted to any versions 40+. Regression?

What's the Bing URL it sends you to? We're fairly conservative at checking the URL, so might just need to add another check (ala bug 1184737).

Hope I can help -- I opened this support entry for the same issue (my bad, didn't see the Bugzilla entry): https://support.mozilla.org/en-US/questions/1094852 As you can see in there, I'm having the same problem. If I do "Hey Cortana, Star Trek," the Bing URL I get is this: https://www.bing.com/search?q=Star%20Trek.&input=2&nclid=C1A156CE9DAEF4A1BFBAEE12388D98D7&form=WNSHCO&cc=US&setlang=en-US jscher2000 over there said that maybe you just need to add a new form= entry into the FF code. From the URL, I'm guessing that it's WNSHCO. Good luck!

Thanks, that's indeed the problem.

Not actually tested yet, will do a build via try. But fairly obvious...

Tested the try build on my Surface Pro, and it's now working for "Hey, Cortana". Well, I did find a couple oddities and made a trivial update to the patch that landed: 1) Sometimes I'm getting form=WNSSSV. At first I though it was the difference between "Hey Cortana search for kittens" and "Hey Cortana *wait for acknowledgement* search for kittens", but I'm not sure. Whatever the cause is, I added it to the list of tokens we redirect for. 2) "Hey Cortana" seems to randomly stop working. It's correctly parsing my voice, but instead of sending a URL to the browser it just does... nothing. This even happens with Chrome set as the default, so it's not a Firefox bug. I also had problems with "Hey Cortana" not even responding at all, so it seems like this just is a flaky Win10 feature. I'm on build 10532.

Approval Request Comment [Feature/regressing bug #]: n/a [User impact if declined]: "Hey Cortana" searches always open in Bing [Describe test coverage new/current, TreeHerder]: none [Risks and why]: Very low, trivial fix. [String/UUID change made/needed]: n/a

Marking affected for 42+

Hi, I just encountered the https://www.bing.com/search?q=%E8%B5%B7%E9%A3%9E%E3%80%82&input=2&nclid=79628F9B942CA4C3C0A0DFB9EA2E7F39&form=WNSSCX&cc=CN&setlang=zh-Hans-CN on Windows 10 TH2, I guess it needs to be added. An idea, maybe we can if form.indexOf("WN") == 0.

I tried searching the directory: C:\Users\YF\AppData\Local\Packages\Microsoft.Windows.Cortana_cw5n1h2txyewy\ and found these: &amp;FORM=WNSPN0 &amp;form=WNSGPH &amp;form=WNSBOX &amp;form=WNSSCX <a href=\"/news/search?q=%e4%bb%8a%e6%97%a5%e5%a4%b4%e6%9d%a1&amp;source=proactive&amp;bu=http%3a%2f%2fnews.qq.com%2fa%2f20151121%2f023628.htm&amp;preIG=496EFD704CC045979829FDBBE5E1F2EF&amp;FORM=EWRE\" The "EWRE" seems is "View All", it does not occur in an external browser (including Microsoft Edge). Others should applies to comment 12.

Tracked for 44 since this is a key scenario.

Dolske, based on comment 13, do we need to revise the patch? Just wondering if there are more string literals that need to be included in our "allowedParams" list. Please let me know.

Comment on attachment 8689785 [details] [diff] [review] Patch v.2 (as landed) Dolske, not sure if you plan to review the string literals based on the additional strings pointed out in comment 13. Please renominate if that's the plan.

Sorry, I didn't get to this before the holiday break. It would have been better to have a new bug for comment 12/13. Reopening a landed bug is best reserved for backouts (either to do breakage or the fix being so wrong it should be backed out). But at this point another bug would be even more confusing, so let's just get caught up here. No big deal. I'll add WNSSCX, since you're seeing it. (I wonder if it has something to do with Chinese locales? Bug 1182308 was another China-specific thing with Cortana.) I'd prefer not to add WNSPN0 unless we know it's actually being used, and what for. (And, yeah, if more of these params keep turning up we may want to rethink the whitelist approach...)

(Re-requesting approval, same as comment 9)

Comment on attachment 8693873 [details] [diff] [review] Rollup patch for Aurora/Beta Fix for search, tested on nightly. Please uplift to aurora and beta.

It is used for top searches section.

I managed to reproduce the issue described in Comment 0 on Windows 10 x86 using Firefox 41.0b9 (20150910171927). This issue is no longer reproducible on Windows 10 x86, using Firefox 43b8 (20151201152349), Firefox 45.0a1 (2015-12-02) and Firefox 44.0a2 (2015-12-02).

Comment on attachment 8693891 [details] WNSPN0 Example Per bug 1287622, Microsoft has disabled using Cortana with browsers other than Edge, so nothing more to do here.