Closed
Bug 1215957
Opened 9 years ago
Closed 9 years ago
[css-grid] Negative line numbers should start counting from the end of the explicit grid
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(2 files)
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
It seems we always start counting from the start of the explicit
grid when there is no <custom-ident> involved.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mats
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8675669 -
Flags: review?(dholbert)
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8675670 [details] [diff] [review]
tests
Review of attachment 8675670 [details] [diff] [review]:
-----------------------------------------------------------------
Drive-by nit on test files -- please fix end-of-line whitespace in both the testcase & reference.
Samples below, for the reference case. (and the testcase has whitespace in the same spots)
::: layout/reftests/css-grid/grid-placement-negative-lines-001-ref.html
@@ +8,5 @@
> + <title>Reference: Placement involving negative line numbers</title>
> + <link rel="author" title="Mats Palmgren" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1215957">
> + <style type="text/css">
> +body,html { color:black; background:white; font-size:12px; padding:0; margin:0; }
> +
Nit: whitespace on blank line here
@@ +52,5 @@
> +<x style="grid-row:4; grid-column-start:6">A -1</x>
> +<x style="grid-row:4; grid-column-start:4">B -1</x>
> +<x style="grid-row:5; grid-column-start:4">A -2</x>
> +<x style="grid-row:6; grid-column-start:3">A -3</x>
> +<x style="grid-row:6; grid-column-start:2">A -4</x>
...and end-of-line whitespace on these "A -1" etc. lines (and on other occurrences of "A -1")
Updated•9 years ago
|
Attachment #8675669 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•9 years ago
|
||
I fixed the test nits.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0e04a7ab19
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4e658173847
Flags: in-testsuite+
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb0e04a7ab19
https://hg.mozilla.org/mozilla-central/rev/d4e658173847
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 6•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/bb0e04a7ab19
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d4e658173847
status-b2g-v2.5:
--- → fixed
Comment 7•9 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #6)
> https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/bb0e04a7ab19
> https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d4e658173847
backed this out on request from mats from b2g v2.5 in http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0869ace8c965
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•