Closed Bug 1215957 Opened 9 years ago Closed 9 years ago

[css-grid] Negative line numbers should start counting from the end of the explicit grid

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(2 files)

It seems we always start counting from the start of the explicit grid when there is no <custom-ident> involved.
Assignee: nobody → mats
Attached patch fix (deleted) — Splinter Review
Attachment #8675669 - Flags: review?(dholbert)
Comment on attachment 8675670 [details] [diff] [review] tests Review of attachment 8675670 [details] [diff] [review]: ----------------------------------------------------------------- Drive-by nit on test files -- please fix end-of-line whitespace in both the testcase & reference. Samples below, for the reference case. (and the testcase has whitespace in the same spots) ::: layout/reftests/css-grid/grid-placement-negative-lines-001-ref.html @@ +8,5 @@ > + <title>Reference: Placement involving negative line numbers</title> > + <link rel="author" title="Mats Palmgren" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1215957"> > + <style type="text/css"> > +body,html { color:black; background:white; font-size:12px; padding:0; margin:0; } > + Nit: whitespace on blank line here @@ +52,5 @@ > +<x style="grid-row:4; grid-column-start:6">A -1</x> > +<x style="grid-row:4; grid-column-start:4">B -1</x> > +<x style="grid-row:5; grid-column-start:4">A -2</x> > +<x style="grid-row:6; grid-column-start:3">A -3</x> > +<x style="grid-row:6; grid-column-start:2">A -4</x> ...and end-of-line whitespace on these "A -1" etc. lines (and on other occurrences of "A -1")
Attachment #8675669 - Flags: review?(dholbert) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: