Closed
Bug 1216434
Opened 9 years ago
Closed 9 years ago
Stop symlinking to the object directory in |mach gradle-install|
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Just one step closer to removing the symlinking entirely.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r?sebastian
This has always been possible with Gradle -- Gradle doesn't care where
in the file tree resources are found. (Gradle is perfectly happy to
take resources from outside of the root project directory.) IntelliJ,
however, displays resources outside of known "content roots" in
special and frankly unhelpful ways. Here, we avoid that on a
technicality: IntelliJ doesn't acknowledge (or even register a content
root!) for the non-standard AndroidManifest.xml locations set in
build.gradle. This means we don't see odd content roots in unexpected
places in IntelliJ.
With this change, the formerly failing command
mach clobber && mach configure && mach gradle-install
completes successfully. That gets us one step closer to being able to
open Fennec in IntelliJ without running additional commands.
Attachment #8676039 -
Flags: review?(s.kaspari)
Updated•9 years ago
|
Attachment #8676039 -
Flags: review?(s.kaspari) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8676039 [details]
MozReview Request: Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r?sebastian
https://reviewboard.mozilla.org/r/22555/#review20095
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2af1c76f67a479b01053a9524b5975c7f2527bf8
Bug 1216434 - Don't symlink to objdir in |mach gradle-install|. r=sebastian
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Updated•7 years ago
|
Component: Build Config → Build Config & IDE Support
Product: Core → Firefox for Android
Target Milestone: mozilla44 → ---
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•