[Tracking Requested - why for this release]: Build Identifier: https://hg.mozilla.org/mozilla-central/rev/f7b746b4e91307448cb0746a41f677bfc23908b0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 ID:20151020031331 Bug 1211363, Bug 1213545 does not fix. INSET shadow is slightly bright. See screenshot. Steps To Reproduce: 1. Open attached testcase 1st regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3d01fdb4df6a1d5a8ac99025537505ad9e0de69c&tochange=8518d9a2673c Regressed by: Bug 1188075

Bug 1216200 did not fix this...

The shading problem doesn't seem to occur because of the offsets. The locations of the blurs are correct, just not the same color. This only happens on Windows. On OS X, the colors look like 42 beta.

I can also reproduce the prroblem on Ubuntu. https://hg.mozilla.org/mozilla-central/rev/0625c68c0abcfe4d10880d15d8fe7d06df3369c9 Mozilla/5.0 (X11; Linux i686; rv:44.0) Gecko/20100101 Firefox/44.0 ID:20151023030245 At least, it happens on Windows and Linux.

The problem here was that we would initialize and fill the min inset rendering's context color to the shadow color rather than black. Thus we would have an alpha color, then mask it against that alpha color, when it should be black. Before the inset box shadow makeover, we'd initialize the shadow rendering context as an alpha only surface, fill it (which i think defaults to black), and only mask the destination once with the shadow color and alpha mask. We initialize the outer box shadows with a fill to black as well and only mask once with the shadow color.

Comment on attachment 8678293 [details] [diff] [review] Properly initialize min inset box shadow context color to black Approval Request Comment [Feature/regressing bug #]: Bug 1188075, speed up inset box shadow rendering [User impact if declined]: There are some inset box shadows that are a lighter color than they should be if they have an alpha component. [Describe test coverage new/current, TreeHerder]: Manual [Risks and why]: Low, this just properly initializes the shadow color to be black. [String/UUID change made/needed]: None

Comment on attachment 8678293 [details] [diff] [review] Properly initialize min inset box shadow context color to black This fix looks safe and stable. Let's uplift to Aurora44.

Alice0775 White, could you please verify this issue is fixed as expected on a latest DevEd44 or Nightly build? Thanks!

Even though this was fixed a while back, I am tracking it for 44 as it's a core scenario that we regressed.

(In reply to Ritu Kothari (:ritu) from comment #13) > Alice0775 White, could you please verify this issue is fixed as expected on > a latest DevEd44 or Nightly build? Thanks! I cannot reproduce the problem on latest Nightly45.0a1 and Aurora44.0a2 anymore. https://hg.mozilla.org/releases/mozilla-aurora/rev/7ea5152b84175b42bfe7519e450d24e546e014db Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 ID:20151129004009 https://hg.mozilla.org/mozilla-central/rev/47b49b0d32360fab04b11ff9120970979c426911 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 ID:20151130030228

(In reply to Alice0775 White from comment #15) > (In reply to Ritu Kothari (:ritu) from comment #13) > > Alice0775 White, could you please verify this issue is fixed as expected on > > a latest DevEd44 or Nightly build? Thanks! > > I cannot reproduce the problem on latest Nightly45.0a1 and Aurora44.0a2 > anymore. > > https://hg.mozilla.org/releases/mozilla-aurora/rev/ > 7ea5152b84175b42bfe7519e450d24e546e014db > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 > ID:20151129004009 > > https://hg.mozilla.org/mozilla-central/rev/ > 47b49b0d32360fab04b11ff9120970979c426911 > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 > ID:20151130030228 Thank you for the verification!