Closed Bug 1216527 Opened 9 years ago Closed 5 years ago

Accepting the TOS (dev agreement) shouldn't be a step in the submission flow

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: magopian, Assigned: rajoria_m, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Following bug 1209226 we now only need to accept the agreement once. Accepting the agreement should therefore not be part of the add-on submission flow anymore. It's currently "step 1", but it should be taken out of those steps, and instead just be a requirement to submitting a new add-on. So when clicking on the "submit a new add-on" link, it should display this dev agreement if it wasn't accepted yet, and then only the first step of the submission "Upload your add-on". If the agreement was already accepted, then it should display the first step straight away.
Blocks: 1203953
Whiteboard: [good first bug]
Can I work on this as my first bug?
Assignee: nobody → rajoria_m
Mentor: mstriemer
I think the easiest solution for this is to remove the link on the first item in the sidebar template [1]. `loop.index` appears to count from 1 so updating that `if` to hide the link if it is equal to 1 should do the trick. [1] https://github.com/mozilla/olympia/blob/54cb1756116902e8c448b86a255f1001023d332a/apps/devhub/templates/devhub/addons/submit/sidebar.html#L24
Product: addons.mozilla.org → addons.mozilla.org Graveyard
I think this patch should do the work.
Thanks Mayank, I've copied this issue to https://github.com/mozilla/addons-server/issues/1696 since we've moved to using GitHub as our bug tracker. Can you please make a pull request against https://github.com/mozilla/addons-server and include a link to https://github.com/mozilla/addons-server/issues/1696 in your description? Sorry this fell off my radar, since we've moved away from bugzilla I missed the emails about this.
Keywords: good-first-bug
Whiteboard: [good first bug]

Closing, as per comment 4

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: