Closed Bug 1216550 Opened 9 years ago Closed 9 years ago

Legacy profiler front isn't destroyed

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

Details

Attachments

(1 file)

patch v1
(deleted), patch
jsantell
: review+
Details | Diff | Splinter Review
That ends up preventing opening a toolbox more than once against the same app/tab/target. This typically ends up in a broken, zombie toolbox that you can't close in WebIDE.
Attached patch patch v1 (deleted) — — Splinter Review
Attachment #8676261 - Flags: review?(jryans)
Comment on attachment 8676261 [details] [diff] [review] patch v1 Review of attachment 8676261 [details] [diff] [review]: ----------------------------------------------------------------- Stealing this review from jryans, but looks good! Is this something that needs uplifted?
Attachment #8676261 - Flags: review?(jryans) → review+
Not a big deal as it's not a very common pattern (opening a toolbox more than once against the same app) But that may prevent some broken toolbox in webide if this LegacyProfilerFront is already in aurora.
"Nice to have" for Aurora I'd say. :)
https://hg.mozilla.org/mozilla-central/rev/230d6e3c6060
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: