Closed Bug 1216569 Opened 9 years ago Closed 9 years ago

Search box text is cut off in rule view / computed view when the panel is really small

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox44 affected, firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: bgrins, Assigned: peregrino)

References

Details

(Whiteboard: [polish-backlog][difficulty=easy])

Attachments

(2 files)

Attached image filter-text-cut-off.png (deleted) —
If you resize the computed view to be really small, then the "Filter Styles" text is cut off. See screenshot and Bug 1200073 Comment 10 - Comment 12.
I think this is due to the padding-right: 23px on .devtools-rule-searchbox, which is presumably there to give room for the 'x' when it's needed: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/toolbars.inc.css#379
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
I think this also gets bit by the weirdness in Bug 1216615, so may as well wait for that to be resolved
Assignee: bgrinstead → colmeiro
Brian, wasn't my intention to change the asignee of the bug (side effect of bzexport!), but I think the patch fixes this issue. Should I add you as reviewer?
Flags: needinfo?(bgrinstead)
(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #4) > Brian, wasn't my intention to change the asignee of the bug (side effect of > bzexport!), but I think the patch fixes this issue. Should I add you as > reviewer? Hi Hernán, thanks for the patch. I'll take a look at it
Flags: needinfo?(bgrinstead)
Comment on attachment 8681704 [details] [diff] [review] Remove right margin for placeholder Review of attachment 8681704 [details] [diff] [review]: ----------------------------------------------------------------- Nice and simple, fixes the problem and I don't see any issue. Can you update the commit message to say something like 'Only add right padding to rule searchbox when it is filled' and then add me as the reviewer? We should handle RTL for this but that's another bug.
Attachment #8681704 - Flags: review+
(In reply to Brian Grinstead [:bgrins] from comment #6) > We should handle RTL for this but that's another bug. Filed Bug 1220839
Blocks: 1220839
I went ahead and update the commit message and pushed to fx-team
Thanks for that!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Reproduced this bug according to 44.0a1 (2016-10-20) Verified is done by Latest Beta Build ID 20160301003640 User Agent Mozilla/5.0 (Windows NT 6.3; rv:45.0) Gecko/20100101 Firefox/45.0 Tested OS-Windows8.1 32bit
QA Whiteboard: [bugday-20160302]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: