Closed
Bug 1216569
Opened 9 years ago
Closed 9 years ago
Search box text is cut off in rule view / computed view when the panel is really small
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox44 affected, firefox45 fixed)
RESOLVED
FIXED
Firefox 45
People
(Reporter: bgrins, Assigned: peregrino)
References
Details
(Whiteboard: [polish-backlog][difficulty=easy])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
If you resize the computed view to be really small, then the "Filter Styles" text is cut off.
See screenshot and Bug 1200073 Comment 10 - Comment 12.
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 1•9 years ago
|
||
I think this is due to the padding-right: 23px on .devtools-rule-searchbox, which is presumably there to give room for the 'x' when it's needed: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/toolbars.inc.css#379
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 2•9 years ago
|
||
I think this also gets bit by the weirdness in Bug 1216615, so may as well wait for that to be resolved
Depends on: 1216615
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: bgrinstead → colmeiro
Assignee | ||
Comment 4•9 years ago
|
||
Brian, wasn't my intention to change the asignee of the bug (side effect of bzexport!), but I think the patch fixes this issue. Should I add you as reviewer?
Flags: needinfo?(bgrinstead)
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #4)
> Brian, wasn't my intention to change the asignee of the bug (side effect of
> bzexport!), but I think the patch fixes this issue. Should I add you as
> reviewer?
Hi Hernán, thanks for the patch. I'll take a look at it
Flags: needinfo?(bgrinstead)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8681704 [details] [diff] [review]
Remove right margin for placeholder
Review of attachment 8681704 [details] [diff] [review]:
-----------------------------------------------------------------
Nice and simple, fixes the problem and I don't see any issue. Can you update the commit message to say something like 'Only add right padding to rule searchbox when it is filled' and then add me as the reviewer?
We should handle RTL for this but that's another bug.
Attachment #8681704 -
Flags: review+
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #6)
> We should handle RTL for this but that's another bug.
Filed Bug 1220839
Blocks: 1220839
Reporter | ||
Comment 8•9 years ago
|
||
I went ahead and update the commit message and pushed to fx-team
Assignee | ||
Comment 10•9 years ago
|
||
Thanks for that!
Comment 11•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment 12•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Comment 13•9 years ago
|
||
Reproduced this bug according to 44.0a1 (2016-10-20)
Verified is done by Latest Beta
Build ID 20160301003640
User Agent Mozilla/5.0 (Windows NT 6.3; rv:45.0) Gecko/20100101 Firefox/45.0
Tested OS-Windows8.1 32bit
QA Whiteboard: [bugday-20160302]
status-b2g-v2.5:
fixed → ---
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•