Closed
Bug 1216590
Opened 9 years ago
Closed 9 years ago
Dismantle last bits of app-manager into WebIDE
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(firefox45 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
Firefox 45
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Once bug 1007061 lands, there will still be some resource in /devtools/app-manager/, files being still used by WebIDE. We should integrate them into WebIDE folders or get rid of these deps.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=453b75353826
Assignee | ||
Comment 3•9 years ago
|
||
Also includes some require(Services) / require(promise) cleanups as well as some removal of app-manager references. (that are not about the webide/modules/app-manager module!) I also tried to clean bugzilla from some app-manager bugs/references.
Assignee | ||
Updated•9 years ago
|
Attachment #8677603 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66e1a83fe740
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5482a4ab59a4
Assignee | ||
Comment 6•9 years ago
|
||
Last time you are going to hear about the app manager ;-) Wait?! No, there is this the webide module!!
Attachment #8680711 -
Flags: review?(jryans)
Assignee | ||
Updated•9 years ago
|
Attachment #8678990 -
Attachment is obsolete: true
Comment on attachment 8680711 [details] [diff] [review] patch v3 Review of attachment 8680711 [details] [diff] [review]: ----------------------------------------------------------------- Great work! :D ::: browser/locales/jar.mn @@ +77,5 @@ > locale/browser/devtools/connection-screen.dtd (%chrome/browser/devtools/connection-screen.dtd) > locale/browser/devtools/connection-screen.properties (%chrome/browser/devtools/connection-screen.properties) > locale/browser/devtools/font-inspector.dtd (%chrome/browser/devtools/font-inspector.dtd) > locale/browser/devtools/har.properties (%chrome/browser/devtools/har.properties) > + locale/browser/devtools/app-validator.properties (%chrome/browser/devtools/app-validator.properties) I believe this will cause all the strings to be re-translated... not sure it's worth it? On the other hand, it's probably left untranslated in many locales. I leave it up to you.
Attachment #8680711 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Do not rename app-manager.properties.
Attachment #8681885 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8680711 -
Attachment is obsolete: true
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a8cc3e63866f20e70104c6b426ea93463a0e02cb Bug 1216590 - Merge last bits of app-manager into WebIDE. r=jryans
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8cc3e63866f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment 11•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a8cc3e63866f
status-b2g-v2.5:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•