In converting a few nsAuto*Ptr things to UniquePtr, one pattern that comes up is: mAutoPtr = new (fallible) T[...]; which has to be converted like so: mUniquePtr.reset(new (fallible) T[...]); I think converting it like so would be nicer: mUniquePtr = MakeUniqueFallible<T[]>(...); which is a little longer, but reads a little more idiomatically and doesn't use |new|.

Reasonable. Separate header from the existing, is all I want here. :-) If we adopt <memory> at some point, want to keep extensions separated out.

How about mUniquePtr = MakeUnique<T[]>(..., fallible) ?

Don't think so. It seems very worth preserving the sense that the arguments passed in, are exactly passed along. Not to mention there'd then be ambiguity with a constructor that took a |fallible| as its last argument.

Chose to call the file MakeUniqueExtensions in case we ever want to have UniqueFreePtr etc.

Approval Request Comment [Feature/regressing bug #]: none [User impact if declined]: need this to uplift bug 1235605 [Describe test coverage new/current, TreeHerder]: none [Risks and why]: safe [String/UUID change made/needed]: none

Comment on attachment 8703908 [details] [diff] [review] header only uplift for beta Review of attachment 8703908 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!

Comment on attachment 8703908 [details] [diff] [review] header only uplift for beta Need to fix a sec-mod issue. Beta44+