The tooltip of the Firefox Hello icon in the toolbar says "Start a conversation". This should be changed immediately to reflect what Hello Firefox does now with the new journey and should include the name of the product since since that's what we refer to it as in all our marketing and users are unable to find Firefox Hello in the UI.

Sevaan, strings are agreed on bug 1211351 and will be implemented through bug 1213844. Can this bug be closed since it's already covered in the other bugs?

I don't think this is going to be explicitly included in bug 1213844 due to it not having been specified in the original user journey story. Therefore I think we should just keep this open.

The icon's active state tooltip says: "Active conversation" https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#99 Are we getting rid of "conversation" in preference of browsing/sharing? In addition to the tooltip on the toolbar icon, there's also a "Start a conversation…" menu item under Tools: https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#260 Although that might be trickier to fix than just a string change as it wouldn't always start a conversation anymore?

We should change "Active conversation" to say something like "Someone is waiting for you". I have added the string to Bug 1211351. The "Start a conversation..." tooltip is being addressed in Bug 1216791.

There's several states for the icon: loop-call-button3.tooltiptext = Start a conversation loop-call-button3-error.tooltiptext = Error! loop-call-button3-donotdisturb.tooltiptext = Do not disturb loop-call-button3-screensharing.tooltiptext = You are sharing your screen loop-call-button3-active.tooltiptext = Active conversation loop-call-button3-participantswaiting.tooltiptext = Someone is waiting for you in a conversation Although I just tested in Release and the icons do show the updated icon (filled - default, blue - in conversation, green - sharing tabs, empty - do not disturb), the tooltip always stays as "Start a conversation"...

Here is my proposition aligned with what we have on bug 1211351: loop-call-button3.tooltiptext = Browse this page with a friend loop-call-button3-error.tooltiptext = Error! loop-call-button3-donotdisturb.tooltiptext = Notifications turned off loop-call-button3-screensharing.tooltiptext = You are sharing your tabs loop-call-button3-active.tooltiptext = You are sharing your tabs loop-call-button3-participantswaiting.tooltiptext = Someone is waiting for you loop-call-button3-screensharing.tooltiptext and loop-call-button3-active.tooltiptext both say "You are sharing your tabs" since when you are in a conversation in 44 you'll always be sharing your tabs. Sevaan, sounds OK?

Sounds great. Thanks Romain!

(In reply to Romain Testard [:RT] from comment #6) > loop-call-button3-screensharing.tooltiptext and > loop-call-button3-active.tooltiptext both say "You are sharing your tabs" > since when you are in a conversation in 44 you'll always be sharing your > tabs. What should happen when the user clicks pause or stop in the notification bar?

Pause is a new state, thanks for remembering that. We can just say "Paused" for it. Stop doesn't need a special message since it reverts back to Browse this page with a friend.

Did we not discuss "Restart" rather than "Paused" in bug 1211351?

Sorry, you are correct. There have been so many discussions in so many different places. I felt like we'd tackled this. "Restart"!

Hey Mark, I've talked offline with Romain about this string change: loop-call-button3-donotdisturb.tooltiptext = Notifications turned off It is for 45 so this patch does not modify it. However, we should take it into account for 45.

Comment on attachment 8683068 [details] [diff] [review] Change the tooltip of the Hello icon in the toolbar Review of attachment 8683068 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties @@ +95,5 @@ > > # LOCALIZATION NOTE(loop-call-button3.label): This is a brand name, request > # approval before you change it. > loop-call-button3.label = Hello > +loop-call-button3.tooltiptext = Browse this page with a friend As per the other bug I just commented on, we need to change the string id here. I'd suggest changing all of these to start with loop-call-button4, as this helps L10n to know they belong to the same part of the display.

Patch ready to be reviewed

Comment on attachment 8683656 [details] [diff] [review] Change the tooltip of the Hello icon in the toolbar Review of attachment 8683656 [details] [diff] [review]: ----------------------------------------------------------------- Regrettably, this is the wrong way around! Instead of changing all the string IDs, because the code looks like it depends on it, you should change only the ID of the string that is in fact changing and update the code to not depend on the prefix anymore. I'm pretty sure your next attempt will be spot-on ;-)

Hey Mike, I've just following what Mark suggested in comment 13. My point is that if we change just a few ID's even if we change the code to no depend on the prefix, could be a bit confusing. But I understand that we should only change those IDs that has been changed. Let me upload a new patch

The code has no dependency with the tooltip IDs. Could you review it?

(In reply to Mike de Boer [:mikedeboer] from comment #15) > Comment on attachment 8683656 [details] [diff] [review] > Change the tooltip of the Hello icon in the toolbar > > Review of attachment 8683656 [details] [diff] [review]: > ----------------------------------------------------------------- > > Regrettably, this is the wrong way around! Instead of changing all the > string IDs, because the code looks like it depends on it, you should change > only the ID of the string that is in fact changing and update the code to > not depend on the prefix anymore. > I'm pretty sure your next attempt will be spot-on ;-) Mike: did you see comment 13? I thought L10n like to keep the string ids similar in this case (including the number), as it helps them identify items that are the same, even though it causes some extra string bumps. But as we're not sure, lets ask them... Axel, which of the patches is best here? Change all the ids, or just the ones for the strings we're changing?

The only real requirement is to keep together a label and its accesskey, since there are tools that display them together (or try to). There's no hard requirement for tooltips. In this specific case I think we're changing way too many strings, forcing people to re-localize them. Personally I would go with: -loop-call-button3.tooltiptext = Start a conversation +loop-call-button3.tooltiptext2 = Browse this page with a friend -loop-call-button3-active.tooltiptext = Active conversation +loop-call-button3-active.tooltiptext2 = You are sharing your tabs -loop-call-button3-participantswaiting.tooltiptext = Someone is waiting for you in a conversation +loop-call-button3-participantswaiting.tooltiptext2 = Someone is waiting for you

Patch updated to fit the requirements of the l10n team.

Wrong patch uploaded sorry. This is the good one

Comment on attachment 8687211 [details] [diff] [review] Change the tooltip of the Hello icon in the toolbar. Review of attachment 8687211 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser-loop.js @@ -287,3 @@ > } else if (aReason == "login" && this.MozLoopService.userProfile) { > state = "active"; > - mozL10nId += "-active"; What if you kept all this here and simply added: ```js suffix += "2"; ``` for the strings you updated? @@ -300,1 @@ > } `suffix += "2";`

Hey Mike! I've changed the patch as you suggested in comment 22. Pleasee check it and let me know if there is something wrong =)

Comment on attachment 8688860 [details] [diff] [review] Change the tooltip of the Hello icon in the toolbar. Review of attachment 8688860 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! r=me with the one change below. ::: browser/base/content/browser-loop.js @@ +304,5 @@ > this.updateTooltiptext(mozL10nId + suffix); > this.toolbarButton.node.setAttribute("state", state); > }); > return; > } I think ```js } else { suffix += "2"; } ``` would work here as well, instead of the three lines below.

Last comment applied to the patch