Closed
Bug 1217500
Opened 9 years ago
Closed 9 years ago
Add UI for inverting display tree in memory tool
Categories
(DevTools :: Memory, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: jsantell, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8678985 -
Flags: review?(jsantell)
Assignee | ||
Updated•9 years ago
|
Attachment #8678381 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8678985 [details] [diff] [review]
Add UI for inverting display tree in memory tool
Review of attachment 8678985 [details] [diff] [review]:
-----------------------------------------------------------------
nit
::: devtools/client/memory/actions/snapshot.js
@@ +104,5 @@
> breakdown = getState().breakdown;
> + dispatch({ type: actions.TAKE_CENSUS_START, snapshot, inverted, breakdown });
> + let opts = inverted ? { asInvertedTreeNode: true } : { asTreeNode: true };
> + census = yield heapWorker.takeCensus(snapshot.path, { breakdown }, opts);
> + } while (inverted !== getState().inverted ||
put the while on a new line since it got huge
do {
...
}
while (...||
...);
Attachment #8678985 -
Flags: review?(jsantell) → review+
Comment 6•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/fx-team/rev/3af8b8e56340 since I didn't know whether it was this or bug 1218560 leaking like https://treeherder.mozilla.org/logviewer.html#?job_id=5354136&repo=fx-team
Assignee | ||
Comment 7•9 years ago
|
||
Figuring out which patch triggered the leaks.
Try push with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=970abc321d0f
Comment 9•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•