IMEContentObserver may need to change notifications to send when TextInputProcessor begins input transaction. In current design, IMEContentObserver needs to retrieve IMENotificationRequests at every change. However, if nsIWidget returns a reference to its IMENotificationRequests, IMEContentObserver can call it only once. For that purpose, this patch changes nsIWidget::GetIMENotificationRequests() to nsIWidget::IMENotificationRequestsRef() and make it return |const IMENotificationRequests&|. However, if the lifetime of the instance of IMENotificationRequest is shorter than the widget instance's, it's dangerous. Therefore, it always returns TextEventDispatcher::mIMENotificationRequests. TextEventDispatcher's lifetime is longer than the widget. Therefore, this guarantees the lifetime. On the other hand, widget needs to update TextEventDispatcher::mIMENotificationRequests before calls of nsIWidget::IMENotificationRequestsRef(). Therefore, this patch makes TextEventDispatcher update proper IMENotificationRequests when it gets focus or starts new input transaction and clear mIMENotificationRequests when it loses focus. Note that TextEventDispatcher gets proper requests both from native text event dispatcher listener (typically, implemented by native IME handler class) and TextInputProcessor when TextInputProcessor has input transaction because even if TextInputProcessor overrides native IME, native IME still needs to know the content changes since they may get new input transaction after that. However, there may not be native IME handler in content process. If it runs in Android, PuppetWidget may have native IME handler because widget directly handles IME in e10s mode for Android. Otherwise, native IME handler is in its parent process. So, if TextInputHandler has input transaction in content process, PuppetWidget needs to behave as native event handler. Therefore, this patch makes PuppetWidget inherit TextEventDispatcherListener and implements PuppetWidget::IMENotificationRequestsRef(). Review commit: https://reviewboard.mozilla.org/r/131572/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/131572/

IMEContentObserver can store pointer of IMENotificationRequests of its mWidget. Therefore, it can check the requests dynamically when it receives content change or layout change. This patch makes IMEContentObserver stores IMENotificationRequests as pointer and check it at every change notification received. Additionally, notification request may be changed due to focus move or something. Therefore, this patch makes IMEContentObserver and IMEContentObserver::IMENotificationSender() check if the notifications are still necessary. Review commit: https://reviewboard.mozilla.org/r/131574/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/131574/

For testing IMEContentObserver, text change, selection change and position change notifications should be exposed to JS with nsITextInputProcessorNotification. Review commit: https://reviewboard.mozilla.org/r/131576/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/131576/

IMEContentObserver notifies IME of 3 notifications at most when editor is changed. The order is: 1. text change (with merged range if 2 or more change occurred during an edit transaction) 2. selection change (only the latest selection change. other changes occurred before that during an editor transaction are ignored) 3. position change (scrolled, resized, window moved, etc) This does not check the behavior in designMode because some operation in testWithHTMLEditor() causes unexpected behavior, e.g., moving focus. It *might* be bug of design mode. However, it doesn't matter for this bug. The important thing of this bug is, there should be automated tests for IMEContentObserver. And fortunately, IMEContentObserver does not check the type of editor. So, it's enough to test only contenteditable element for HTMLEditor at least for now. Therefore, I gave up to test it in designMode for now. Review commit: https://reviewboard.mozilla.org/r/131578/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/131578/

Comment on attachment 8859865 [details] Bug 1217700 part.1 nsIWidget should return reference to IMENotificationRequests Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131572/diff/1-2/

Comment on attachment 8859866 [details] Bug 1217700 part.2 IMEContentObserver should observe all possible notifications and check if it should be notified when it occurs Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131574/diff/1-2/

Comment on attachment 8859867 [details] Bug 1217700 part.3 Expose text change, selection change and position change notifications to nsITextInputProcessorCallback with nsITextInputProcessorNotification Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131576/diff/1-2/

Comment on attachment 8859868 [details] Bug 1217700 part.4 Add automated tests for IMEContentObserver Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131578/diff/1-2/